Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix markdown syntax in "Making subsystems exportable ..." docs #20902

Merged
merged 2 commits into from May 15, 2024
Merged

Fix markdown syntax in "Making subsystems exportable ..." docs #20902

merged 2 commits into from May 15, 2024

Conversation

huonw
Copy link
Contributor

@huonw huonw commented May 10, 2024 •
edited

This makes two minor adjustments to the "Making subsystems exportable ..." docs from #20730:

  • close the :::note admonitions with :::
  • indent some items to be nested within the relevant list items

Fixes #20891

image

@huonw huonw added this to the 2.21.x milestone May 10, 2024
@huonw huonw added the release-notes:not-required PR doesn't require mention in release notes label May 10, 2024
@huonw huonw marked this pull request as ready for review May 10, 2024 06:59
@huonw huonw merged commit bef63e9 into main May 15, 2024
25 checks passed
@huonw huonw deleted the huonw/20891-subsystem-export-docs branch May 15, 2024 05:03
WorkerPants pushed a commit that referenced this pull request May 15, 2024
@huonw @WorkerPants
Fix markdown syntax in "Making subsystems exportable ..." docs (#20902)
54627a0 
This makes two minor adjustments to the "Making subsystems exportable
..." docs from #20730:

- close the `:::note` admonitions with `:::`
- indent some items to be nested within the relevant list items

Fixes #20891
@WorkerPants
Copy link
Member

I tried to automatically cherry-pick this change back to each relevant milestone, so that it is available in those older releases of Pants.

✔️ 2.21.x

Successfully opened #20928.

Thanks again for your contributions!

🤖 Beep Boop here's my run link

huonw added a commit that referenced this pull request May 15, 2024
@WorkerPants @huonw
Fix markdown syntax in "Making subsystems exportable ..." docs (Cherr…
4065433 
…y-pick of #20902) (#20928)

This makes two minor adjustments to the "Making subsystems exportable
..." docs from #20730:

- close the `:::note` admonitions with `:::`
- indent some items to be nested within the relevant list items

Fixes #20891

Co-authored-by: Huon Wilson <huon@exoflare.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjyw benjyw benjyw approved these changes

@lilatomic lilatomic Awaiting requested review from lilatomic

@thejcannon thejcannon Awaiting requested review from thejcannon

Assignees
No one assigned
Labels
category:documentation release-notes:not-required PR doesn't require mention in release notes
Projects
None yet
Milestone
2.21.x
Development

Successfully merging this pull request may close these issues.

"Making subsystems exportable with their default lockfile" docs render funny
3 participants
@huonw @WorkerPants @benjyw