Fix serializing of time/date columns using yaml serializer #1458
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are currently using paper_trail and have billions of items in the
versions
table and the table is huge.I noticed, that for yaml serializer date/time objects are serialized as ruby objects. Something like
This generates 179 bytes per field.
But that should be serialized into the string. Something like
--- 2024-01-27 18:03:07 UTC
That is 28 bytes long, so 150 bytes difference.
Considering that most people have at least 2 datetime columns (
created_at
andupdated_at
) for each table, that saves 300 bytes per row in the table.For example, if we have a table with 4 billion rows, that is
4 * 10^9 * 300 / 10^9
= 1200 GB 馃槺 saved.master
(if not - rebase it).code introduces user-observable changes.
and description in grammatically correct, complete sentences.