Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Armv7 Docker Build #156

Merged
merged 1 commit into from
Feb 28, 2022
Merged

Fix Armv7 Docker Build #156

merged 1 commit into from
Feb 28, 2022

Conversation

bauerj
Copy link
Member

@bauerj bauerj commented Feb 25, 2022

Another attempt at #145 馃槄

This time with help from @schnuffle.

Upstream pikepdf provides binary wheels for amd64 and arm64 but not armv7. This means we have to compile it on that architecture. This also means that we have to compile its dependency qpdf manually.

This takes almost forever (two hours!) but with improved Docker caching, this should hopefully be not much of an issue.

Closes: #150

@paperless-ngx-secretary paperless-ngx-secretary bot added ci-cd non-trivial Requires approval by several team members labels Feb 25, 2022
@coveralls
Copy link

coveralls commented Feb 25, 2022

Pull Request Test Coverage Report for Build 1903099095

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.01%

Totals Coverage Status
Change from base Build 1901054761: 0.0%
Covered Lines: 3950
Relevant Lines: 4293

馃挍 - Coveralls

@bauerj bauerj requested a review from a team February 25, 2022 23:24
Dockerfile Show resolved Hide resolved
@bauerj
Copy link
Member Author

bauerj commented Feb 26, 2022

Thanks to the both of you!

Some further remarks on Docker caching:

The currently used strategy local has a warning that "At the moment caches are copied over the existing cache so it keeps growing." This should not happen with a gha-type cache.

@schnuffle
Copy link
Contributor

One minor note, in my POC I've only pulled qpdf and did not checkout a distinct version.

Okay, checked the latest state and somebody else has been faster.

Good job

@qcasey qcasey merged commit aa39abc into dev Feb 28, 2022
@qcasey qcasey deleted the docker-fix-ci branch February 28, 2022 00:54
@qcasey
Copy link
Member

qcasey commented Feb 28, 2022

#150 (comment)

@qcasey qcasey mentioned this pull request Mar 1, 2022
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ci-cd non-trivial Requires approval by several team members
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants