Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: dont initialize page numbers, allow split with browser pdf viewer #6314

Merged
merged 1 commit into from
Apr 7, 2024

Conversation

shamoon
Copy link
Member

@shamoon shamoon commented Apr 7, 2024

Proposed change

Forgot to include this in #6304, my bad

Closes #6300 , actually

Type of change

  • Bug fix: non-breaking change which fixes an issue.
  • New feature / Enhancement: non-breaking change which adds functionality. Please read the important note above.
  • Breaking change: fix or feature that would cause existing functionality to not work as expected.
  • Documentation only.
  • Other. Please explain:

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have included testing coverage for new code in this PR, for backend and / or front-end changes.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@shamoon shamoon requested a review from a team as a code owner April 7, 2024 14:04
@github-actions github-actions bot added the bug Bug report or a Bug-fix label Apr 7, 2024
@shamoon
Copy link
Member Author

shamoon commented Apr 7, 2024

Just to be explicit here:
Screenshot 2024-04-07 at 7 05 06 AM

@shamoon shamoon enabled auto-merge (squash) April 7, 2024 14:05
Copy link

codecov bot commented Apr 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.12%. Comparing base (fe824e0) to head (8884e7b).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #6314   +/-   ##
=======================================
  Coverage   97.12%   97.12%           
=======================================
  Files         420      420           
  Lines       16917    16915    -2     
  Branches     1210     1286   +76     
=======================================
- Hits        16430    16429    -1     
+ Misses        487      484    -3     
- Partials        0        2    +2     
Flag Coverage Δ
backend 95.94% <ø> (+0.01%) ⬆️
frontend 98.56% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shamoon shamoon changed the title Fix: dont initialize page numbers Fix: dont initialize page numbers, allow split with browser pdf viewer Apr 7, 2024
@shamoon shamoon disabled auto-merge April 7, 2024 14:18
@shamoon shamoon enabled auto-merge (squash) April 7, 2024 14:18
@shamoon shamoon merged commit 974dd24 into dev Apr 7, 2024
31 checks passed
@shamoon shamoon deleted the fix-6300-2 branch April 7, 2024 15:16
@shamoon shamoon added this to the Next Release milestone Apr 7, 2024
DlieBG pushed a commit to DlieBG/paperless-ngx that referenced this pull request Apr 14, 2024
Copy link
Contributor

github-actions bot commented May 8, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns. See our contributing guidelines for more details.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bug report or a Bug-fix frontend small-change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BUG] Split feature is disabled when using browser pdf viewer
2 participants