Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: global search tweaks #6674

Merged
merged 6 commits into from May 13, 2024
Merged

Enhancement: global search tweaks #6674

merged 6 commits into from May 13, 2024

Conversation

shamoon
Copy link
Member

@shamoon shamoon commented May 10, 2024

Proposed change

Few things:

  • Always show the search button (when theres text)
  • Enter immediately runs advanced search, no need to wait for results
  • Allow ctrl ( for Mac) + click / Enter to open links (docs, filtering, etc) in a new tab
  • Tiny bit of housekeeping

Closes #6648
See #6632 (comment)

Type of change

  • Bug fix: non-breaking change which fixes an issue.
  • New feature / Enhancement: non-breaking change which adds functionality. Please read the important note above.
  • Breaking change: fix or feature that would cause existing functionality to not work as expected.
  • Documentation only.
  • Other. Please explain: change

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have included testing coverage for new code in this PR, for backend and / or front-end changes.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@shamoon shamoon requested a review from a team as a code owner May 10, 2024 20:27
@paperless-ngx-secretary paperless-ngx-secretary bot added frontend non-trivial Requires approval by several team members labels May 10, 2024
@shamoon shamoon changed the title Change: global search tweaks Enhancement: global search tweaks May 10, 2024
@github-actions github-actions bot added the enhancement New feature label May 10, 2024
@shamoon shamoon added this to the Next Release milestone May 10, 2024
@shamoon shamoon enabled auto-merge (squash) May 10, 2024 20:27
@shamoon shamoon force-pushed the feature-global-search-tweaks branch from 431860e to 0c3dbc5 Compare May 10, 2024 20:27
Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.19%. Comparing base (7983487) to head (63d8734).

❗ Current head 63d8734 differs from pull request most recent head 9bdf1d8. Consider uploading reports for the commit 9bdf1d8 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #6674   +/-   ##
=======================================
  Coverage   97.19%   97.19%           
=======================================
  Files         436      436           
  Lines       17969    17975    +6     
  Branches     1526     1433   -93     
=======================================
+ Hits        17465    17471    +6     
- Misses        501      504    +3     
+ Partials        3        0    -3     
Flag Coverage Δ
backend 95.88% <ø> (ø)
frontend 98.63% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shamoon shamoon force-pushed the feature-global-search-tweaks branch from 0c3dbc5 to 63d8734 Compare May 13, 2024 01:48
@shamoon shamoon force-pushed the feature-global-search-tweaks branch from 63d8734 to 9bdf1d8 Compare May 13, 2024 16:05
@shamoon shamoon merged commit a1e4365 into dev May 13, 2024
25 checks passed
@shamoon shamoon deleted the feature-global-search-tweaks branch May 13, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature frontend non-trivial Requires approval by several team members
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants