fixed issue #2632 #2665
Merged
fixed issue #2632 #2665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toContext2d: html2canvas.scale: (this.prop.pageSize.width * this.prop.pageSize.k) / Math.max(this.prop.src.clientWidth, this.prop.src.scrollWidth, this.prop.src.offsetWidth)
|
Could you attach a small test case so I can test it? |
|
I'll send you the link when I get a chance. But I just figured out it should be easier and better to just set the scale to 1. |
this is better than the math and able to keep the original scale/size
|
https://kakugiki.github.io/jspdf_test/ |
|
@HackbrettXXX it's been a while, did you get a chance to look into this. This may also help to solve issue #2766. |
|
Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
toContext2d: html2canvas.scale: (this.prop.pageSize.width * this.prop.pageSize.k) / Math.max(this.prop.src.clientWidth, this.prop.src.scrollWidth, this.prop.src.offsetWidth)