Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getTextDimensions should automatically infer numberOfLines if maxTextWidth is provided #2824

Merged
merged 7 commits into from Aug 10, 2020
Merged

getTextDimensions should automatically infer numberOfLines if maxTextWidth is provided #2824

merged 7 commits into from Aug 10, 2020

Commits on Jul 26, 2020

  1. Now maxTextWidth can be specified and the number of lines can automat… 

    …ically be inferred based on that and the text width
    @Nnoerregaard
    Nnoerregaard committed Jul 26, 2020
    Copy the full SHA
    6a6c4ce View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2020

  1. Change the name of maxTextWidth to maxWidth so that it is consistent … 

    …with the naming for text
    @Nnoerregaard
    Nnoerregaard committed Jul 27, 2020
    Copy the full SHA
    0ef7aa2 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2020

  1. Changed to using splitTextToSize and updated the test to fit the actu… 

    …al result
    @Nnoerregaard
    Nnoerregaard committed Jul 30, 2020
    Copy the full SHA
    cb495b9 View commit details
    Browse the repository at this point in the history

  2. Changed to using splitTextToSize for arrays as well to stay consistent

    @Nnoerregaard
    Nnoerregaard committed Jul 30, 2020
    Copy the full SHA
    facb6ef View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2020

  1. Update tests and change cell.js according to PR feedback

    Niklas Moss committed Jul 31, 2020
    Copy the full SHA
    dbe4354 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2020

  1. Now it should work exactly the same as the text method

    Niklas Moss committed Aug 2, 2020
    Copy the full SHA
    37e474a View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2020

  1. Merge branch 'master' into handleMultilineText

    @HackbrettXXX
    HackbrettXXX committed Aug 10, 2020
    Copy the full SHA
    ee42ba8 View commit details
    Browse the repository at this point in the history