Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo.toml: structopt: Migrate to clap #125

Merged

Conversation

tgonzalezorlandoarm
Copy link
Member

According to TeXitoi/structopt#525,
structopt has entered maintenance mode, and clap should be used
for new development.
* Migrate to clap so that nightly builds succeed as well.

This PR is dependent on parallaxsecond/parsec#753

So that lints can be searched for easily.

Signed-off-by: Tomás González <tomasagustin.gonzalezorlando@arm.com>
The private_in_public rule has been replaced with three other lints:

 * private_interfaces
 * private_bounds
 * renamed_and_removed_lints

Please refer to
https://rust-lang.github.io/rfcs/2145-type-privacy.html
for more information.

Signed-off-by: Tomás González <tomasagustin.gonzalezorlando@arm.com>
According to TeXitoi/structopt#525,
structopt has entered maintenance mode, and clap should be used
for new development.

 * Migrate to clap so that nightly builds succeed as well.

Signed-off-by: Tomás González <tomasagustin.gonzalezorlando@arm.com>
4.3.24 is the highest clap version that is compatible with the
current MSRV (1.66.0)

 * Fix clap_lex to 0.5.0 to be compatible with MSRV as well.
 * Fix anstyle to 1.0.2 to be compatible with MSRV as well.
 * Fix anstyle-query to 1.0.0 to be compatible with MSRV as well.
 * Fix anstyle-parse to 0.2.1 to be compatible with MSRV as well.

Signed-off-by: Tomás González <tomasagustin.gonzalezorlando@arm.com>
@tgonzalezorlandoarm
Copy link
Member Author

The failure in theCI - mismatch checker, is expected, as a mirror PR is expected to be merged in parsec: parallaxsecond/parsec#753

@tgonzalezorlandoarm tgonzalezorlandoarm merged commit 22fc7b4 into parallaxsecond:main Mar 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants