Replace pytest-relaxed with plain pytest.raises

[mgorny]

There is really no technical reason to bring pytest-relaxed to call
@raises as a decorator while plain pytest works just fine. Plus,
pytest.raises() is used in test_sftp already.

pytest-relaxed causes humongous breakage to other packages
on the system. It has been banned from Gentoo for this reason.

This is alternative to #1543 that doesn't remove tests.

[mgorny]

Ping.

[bnavigator]

Any plans to merge this?

pytest-relaxed is broken with pytest > 5.4, even with bitprophet/pytest-relaxed#10, it is broken with pytest > 6.1

bitprophet/pytest-relaxed#12

[radez]

+1 to remove this dependency

[mgorny]

Ping. Two years have passed already.

[bskinn]

Thanks for pinging to bring this back up.

pytest-relaxed causes humongous breakage to other packages on the system. It has been banned from Gentoo for this reason.

Other packages on what system?

Are you saying that paramiko might be packaged into Gentoo, if not for the pytest-relaxed dependency? In other words, is there strong interest in paramiko being packaged in Gentoo, but it's blocked?

[mgorny]

pytest-relaxed causes humongous breakage to other packages on the system. It has been banned from Gentoo for this reason.

Other packages on what system?

On a Gentoo system. Basically, when pytest-relaxed was installed in order to run paramiko's tests, we've seen huge fallout from other Python packages. Please bear in mind that pytest loads all installed plugins by default, and pytest-relaxed changes its behavior quite a lot.

Are you saying that paramiko might be packaged into Gentoo, if not for the pytest-relaxed dependency? In other words, is there strong interest in paramiko being packaged in Gentoo, but it's blocked?

It is packaged in Gentoo, with this patch applied on top in order to make the tests work without pytest-relaxed. However, there is strong interest in not having to carry custom patches when the change actually should work for everyone.

[bskinn]

Got it - thanks for the context!

[bitprophet]

Basically, when pytest-relaxed was installed in order to run paramiko's tests, we've seen huge fallout from other Python packages. Please bear in mind that pytest loads all installed plugins by default, and pytest-relaxed changes its behavior quite a lot.

pytest-relaxed needs some love, but it still seems a bit odd that this is my problem here in paramiko or pytest-relaxed, instead of it being a configuration issue when packaging pytest-using kit such that the test phase only uses its specific deps (or such that the prod install facing stage isn't including test-only dependencies).

Surely there are other pytest plugins out there that cause breaking changes - I find it hard to believe that a build/test regime that boils down to "install a very large subset of all pytest plugins all at the same time" was working swimmingly until relaxed came along?

---

I am actually intending to use more pytest-relaxed in Paramiko's suite in the near/mid future, not less, so I can't merge this. However, I would definitely like to give pytest-relaxed the love it needs to work with newer pytests at the very least, and I'm certainly open to discussions about any truly bad behavior that remains after that point.

[mgorny]

I'm not claiming that everything works "swimmingly". I'm talking about the difference between 5% of packages sometimes failing, and 95% of packages being totally broken.