feat: add procfs cmdline #2799
Merged
feat: add procfs cmdline #2799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kakkoyun
approved these changes
May 17, 2024
|
Wondering whether the profiler timeouts for Python and Java are not long enough... seeing similar check failures in other PRs. |
|
I'm worried that this can easily expose secrets in profiling data. I think we should only expose this with a flag on that is off by default. We're working on fixing the tests, they are knowingly broken at the moment. |
brancz
reviewed
May 20, 2024
cmd/parca-agent/main.go
Outdated
| @@ -184,7 +184,8 @@ type FlagsMetadata struct { | |||
| ExternalLabels map[string]string `help:"Label(s) to attach to all profiles."` | |||
| ContainerRuntimeSocketPath string `help:"The filesystem path to the container runtimes socket. Leave this empty to use the defaults."` | |||
|
|
|||
| DisableCaching bool `default:"false" help:"Disable caching of metadata."` | |||
| DisableCaching bool `default:"false" help:"Disable caching of metadata."` | |||
| EnableProcessCmdline bool `default:"false" help:"add /proc/[pid]/cmdline as a label."` | |||
There was a problem hiding this comment.
"add" -> "Add" and please add a note about the potential security implications.
brancz
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Add an extra label for distinguishing processes, especially for java processes where the
comms are the same.What?
Add a procfs label cmdline from
/proc/[pid]/cmdlineHow?
The code is short and self-explanatory.
Test Plan
See the modified integration test.