Add otel profiling support #4579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Meticulous spotted visual differences in 1 of 336 screens tested: view and approve differences detected. Last updated for commit e8278ad. This comment will update as new commits are pushed. |
metalmatze
reviewed
May 2, 2024
There was a problem hiding this comment.
All of these files were deleted. rm -r ui/packages/app/grafana-datasource-plugin/
metalmatze
reviewed
May 2, 2024
There was a problem hiding this comment.
All of these files were deleted. rm -r ui/packages/app/grafana-panel-plugin/.prettierrc.js
brancz
force-pushed
the
otelprofiling
branch
3 times, most recently
from
b7988b6
to
86544d2
Compare
brancz
force-pushed
the
otelprofiling
branch
2 times, most recently
from
77580ac
to
03cbd91
Compare
brancz
force-pushed
the
otelprofiling
branch
2 times, most recently
from
abf5e75
to
5932b36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch implements the otel-profiling format to be accepted by Parca. Generation is a bit wonky as I needed it to not clash with existing
commonandresourcetypes, but that will be gone once the official Go library that contains the generated Go code is updated.As this is partly meant to inform otel-profiling format feedback, to reduce our own bias, use, and behavior of the format, instead of implementing support for otel-profiling in Parca-Agent first, this was instead primarily tested for compatibility by trying to ingest data from the otel-profiling-agent.
One thing to note about that is that the otel agent always normalizes addresses, therefore this currently hardcodes that mode, ideally this would actually be indicated by the otel profiling format (I'm going to bring this up in today's otel profiling meeting).