Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: windows test errors #544

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marcuspang
Copy link

@marcuspang marcuspang commented Jul 14, 2023

Relevant issue: #541

Description

The bundle test was an easy fix, but the rounding differences for some color mix minify tests seem to boil down to how the different OSes handle floating point arithmetic.

After some debugging for this test,

minify_test(
  ".foo { color: color-mix(in lch, peru 40%, palegoldenrod); }",
  ".foo{color:lch(79.7255% 40.4542 84.7634)}",
);

I noticed that p1 and p2 in src\values\color.rs (L2875) don't end up with 0.4 and 0.6, unlike my Unix build.

Couldn't really figure out why the class names were being converted differently either, so I'll only be adding the fix to the bundle.test.mjs file.

Changes

  • replace \ with / for paths used in in-memory filesystem tests (for yarn test)

@marcuspang marcuspang marked this pull request as ready for review July 15, 2023 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant