When rendering declarations of KeyFrames disable minification #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that KeyFrame transformations are not broken * Added Todo to TransformList::to_css as it needs to be refactored and we need more context. * 4 Tests are still broken
|
Another option is to do only whitespace minification in TransformList::to_css, and don't try and change the types. Ideally there should be a optional minification pass added, so to_css only deals with formatting. parse -> [ minify ] -> to_css |
|
Another option would be to turn minify into an enum, expressing white_space only minification and white_space + transformation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so that KeyFrame transformations are not broken
This is mostly to get the ball rolling and to see if this fixes people's use cases around keyframes.