fix-dependency-tag-with-empty-value (#2553)

Solves #2528
parcel-bundler · Feb 9, 2019 · 01174eb · 01174eb
1 parent f23c844
commit 01174eb
Showing 1 changed file with 10 additions and 3 deletions.
diff --git a/packages/core/parcel-bundler/src/assets/HTMLAsset.js b/packages/core/parcel-bundler/src/assets/HTMLAsset.js
@@ -168,18 +168,25 @@ class HTMLAsset extends Asset {
         }
 
         for (let attr in node.attrs) {
-          let elements = ATTRS[attr];
+          const attrVal = node.attrs[attr];
+
+          if (!attrVal) {
+            continue;
+          }
+
           // Check for virtual paths
-          if (node.tag === 'a' && node.attrs[attr].lastIndexOf('.') < 1) {
+          if (node.tag === 'a' && attrVal.lastIndexOf('.') < 1) {
             continue;
           }
 
+          let elements = ATTRS[attr];
+
           if (elements && elements.includes(node.tag)) {
             let depHandler = this.getAttrDepHandler(attr);
             let options = OPTIONS[node.tag];
             node.attrs[attr] = depHandler.call(
               this,
-              node.attrs[attr],
+              attrVal,
               options && options[attr]
             );
             this.isAstDirty = true;