Scope hoisting renaming after babel transforms (#2292)

packages/core/parcel-bundler/src/scope-hoisting/hoist.js

@@ -51,6 +51,8 @@ function hasSideEffects(asset, {sideEffects} = asset._package) {
 module.exports = {
   Program: {
     enter(path, asset) {
+      path.scope.crawl();
+
       asset.cacheData.imports = asset.cacheData.imports || Object.create(null);
       asset.cacheData.exports = asset.cacheData.exports || Object.create(null);
       asset.cacheData.wildcards = asset.cacheData.wildcards || [];

packages/core/parcel-bundler/src/scope-hoisting/renamer.js

@@ -25,9 +25,9 @@ function rename(scope, oldName, newName) {
   }
 
   // Rename binding identifier, and update scope.
-  binding.identifier.name = newName;
+  scope.removeOwnBinding(oldName);
   scope.bindings[newName] = binding;
-  delete scope.bindings[oldName];
+  binding.identifier.name = newName;
 }
 
 module.exports = rename;

packages/core/parcel-bundler/test/integration/scope-hoisting/es6/jsx-pragma/.babelrc

@@ -0,0 +1,3 @@
+{
+	"plugins": ["@babel/plugin-transform-react-jsx"]
+}

packages/core/parcel-bundler/test/integration/scope-hoisting/es6/jsx-pragma/a.js

@@ -0,0 +1,3 @@
+import React from "./react.js";
+
+output = <span>Test</span>;

packages/core/parcel-bundler/test/integration/scope-hoisting/es6/jsx-pragma/react.js

@@ -0,0 +1,9 @@
+// mock for React.createElement
+
+export default {
+	createElement(type, props, children){
+		return {
+			type, props, children
+		};
+	}
+}

packages/core/parcel-bundler/test/integration/scope-hoisting/es6/rename-superclass/a.js

@@ -0,0 +1,5 @@
+import Superclass from './b';
+
+class Test extends Superclass {}
+
+output = new Test().parentMethod();

packages/core/parcel-bundler/test/integration/scope-hoisting/es6/rename-superclass/b.js

@@ -0,0 +1,5 @@
+export default class Superclass {
+	parentMethod(){
+		return 2;
+	}
+}

packages/core/parcel-bundler/test/scope-hoisting.js

@@ -89,6 +89,17 @@ describe('scope hoisting', function() {
       assert.equal(output, 2);
     });
 
+    it('supports renaming superclass identifiers', async function() {
+      let b = await bundle(
+        path.join(
+          __dirname,
+          '/integration/scope-hoisting/es6/rename-superclass/a.js'
+        )
+      );
+      let output = await run(b);
+      assert.equal(output, 2);
+    });
+
     it('supports renaming imports', async function() {
       let b = await bundle(
         path.join(
@@ -446,6 +457,19 @@ describe('scope hoisting', function() {
       assert.deepEqual(output, 'bar');
     });
 
+    it('should support the jsx pragma', async function() {
+      let b = await bundle(
+        path.join(__dirname, '/integration/scope-hoisting/es6/jsx-pragma/a.js')
+      );
+
+      let output = await run(b);
+      assert.deepEqual(output, {
+        children: 'Test',
+        props: null,
+        type: 'span'
+      });
+    });
+
     it('should not nameclash with internal variables', async function() {
       let b = await bundle(
         path.join(__dirname, '/integration/scope-hoisting/es6/name-clash/a.js')