Skip to content

Commit

Permalink
Fix semver version range (#7334)
Browse files Browse the repository at this point in the history
* Bump all semver ranges

* Use semver.minVersion
  • Loading branch information
mischnic committed Nov 21, 2021
1 parent 3eb0fc7 commit 1069398
Show file tree
Hide file tree
Showing 14 changed files with 14 additions and 26 deletions.
2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -53,7 +53,7 @@
"mocha-multi-reporters": "^1.5.1",
"prettier": "2.4.1",
"rimraf": "^2.6.3",
"semver": "^5.4.1",
"semver": "^5.7.1",
"sinon": "^7.3.1"
},
"engines": {
Expand Down
2 changes: 1 addition & 1 deletion packages/core/core/package.json
Expand Up @@ -47,7 +47,7 @@
"json5": "^1.0.1",
"micromatch": "^4.0.2",
"nullthrows": "^1.1.1",
"semver": "^5.4.1"
"semver": "^5.7.1"
},
"devDependencies": {
"graphviz": "^0.0.9",
Expand Down
2 changes: 1 addition & 1 deletion packages/core/package-manager/package.json
Expand Up @@ -34,7 +34,7 @@
"command-exists": "^1.2.6",
"cross-spawn": "^6.0.4",
"nullthrows": "^1.1.1",
"semver": "^5.4.1",
"semver": "^5.7.1",
"split2": "^3.1.1"
},
"peerDependencies": {
Expand Down
14 changes: 1 addition & 13 deletions packages/transformers/babel/src/utils.js
Expand Up @@ -47,7 +47,7 @@ export function enginesToBabelTargets(env: Environment): BabelTargets {
} else {
invariant(typeof engineValue === 'string');
if (!TargetNames.hasOwnProperty(engineName)) continue;
let minVersion = getMinSemver(engineValue);
let minVersion = semver.minVersion(engineValue)?.toString();
targets[engineName] = minVersion ?? engineValue;
}
}
Expand All @@ -69,15 +69,3 @@ export function enginesToBabelTargets(env: Environment): BabelTargets {

return targets;
}

// TODO: Replace with `minVersion` (https://github.com/npm/node-semver#ranges-1)
// once semver has been upgraded across Parcel.
export function getMinSemver(version: string): ?string {
try {
let range = new semver.Range(version);
let sorted = range.set.sort((a, b) => a[0].semver.compare(b[0].semver));
return sorted[0][0].semver.version;
} catch (err) {
return null;
}
}
2 changes: 1 addition & 1 deletion packages/transformers/coffeescript/package.json
Expand Up @@ -25,6 +25,6 @@
"@parcel/utils": "^2.0.1",
"coffeescript": "^2.0.3",
"nullthrows": "^1.1.1",
"semver": "^5.4.1"
"semver": "^5.7.1"
}
}
2 changes: 1 addition & 1 deletion packages/transformers/css/package.json
Expand Up @@ -26,6 +26,6 @@
"nullthrows": "^1.1.1",
"postcss": "^8.3.0",
"postcss-value-parser": "^4.1.0",
"semver": "^5.4.1"
"semver": "^5.7.1"
}
}
2 changes: 1 addition & 1 deletion packages/transformers/html/package.json
Expand Up @@ -26,6 +26,6 @@
"posthtml": "^0.16.5",
"posthtml-parser": "^0.10.1",
"posthtml-render": "^3.0.0",
"semver": "^5.4.1"
"semver": "^5.7.1"
}
}
2 changes: 1 addition & 1 deletion packages/transformers/js/package.json
Expand Up @@ -40,7 +40,7 @@
"micromatch": "^4.0.2",
"nullthrows": "^1.1.1",
"regenerator-runtime": "^0.13.7",
"semver": "^5.4.1"
"semver": "^5.7.1"
},
"devDependencies": {
"@napi-rs/cli": "1.0.4"
Expand Down
2 changes: 1 addition & 1 deletion packages/transformers/postcss/package.json
Expand Up @@ -28,7 +28,7 @@
"nullthrows": "^1.1.1",
"postcss-modules": "^3.2.2",
"postcss-value-parser": "^4.1.0",
"semver": "^5.4.1"
"semver": "^5.7.1"
},
"devDependencies": {
"postcss": "^8.3.0"
Expand Down
2 changes: 1 addition & 1 deletion packages/transformers/posthtml/package.json
Expand Up @@ -26,6 +26,6 @@
"posthtml": "^0.16.5",
"posthtml-parser": "^0.10.1",
"posthtml-render": "^3.0.0",
"semver": "^5.4.1"
"semver": "^5.7.1"
}
}
2 changes: 1 addition & 1 deletion packages/transformers/svg/package.json
Expand Up @@ -26,6 +26,6 @@
"posthtml": "^0.16.5",
"posthtml-parser": "^0.10.1",
"posthtml-render": "^3.0.0",
"semver": "^5.4.1"
"semver": "^5.7.1"
}
}
2 changes: 1 addition & 1 deletion packages/transformers/vue/package.json
Expand Up @@ -27,7 +27,7 @@
"@vue/compiler-sfc": "^3.0.0",
"consolidate": "^0.16.0",
"nullthrows": "^1.1.1",
"semver": "^5.4.1"
"semver": "^5.7.1"
},
"devDependencies": {
"vue": "^3.0.0"
Expand Down
2 changes: 1 addition & 1 deletion packages/utils/babel-plugin-transform-runtime/package.json
Expand Up @@ -19,7 +19,7 @@
},
"dependencies": {
"@babel/plugin-transform-runtime": "^7.8.3",
"semver": "^5.4.1"
"semver": "^5.7.1"
},
"devDependencies": {
"@babel/core": "^7.12.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/utils/babel-preset-env/package.json
Expand Up @@ -19,7 +19,7 @@
},
"dependencies": {
"@babel/preset-env": "^7.4.0",
"semver": "^5.4.1"
"semver": "^5.7.1"
},
"devDependencies": {
"@babel/core": "^7.12.0"
Expand Down

0 comments on commit 1069398

Please sign in to comment.