Don't process inline <style> elements as CSS modules (#7921)

parcel-bundler · Apr 8, 2022 · 39b330e · 39b330e
1 parent 63f2a97
commit 39b330e
Show file tree

Hide file tree

Showing 5 changed files with 27 additions and 3 deletions.
diff --git a/packages/core/integration-tests/test/css-modules.js b/packages/core/integration-tests/test/css-modules.js
@@ -610,4 +610,15 @@ describe('css modules', () => {
       },
     ]);
   });
+
+  it('should not process inline <style> elements as a CSS module', async function () {
+    await bundle(
+      path.join(__dirname, '/integration/css-modules-style/index.html'),
+    );
+    let contents = await outputFS.readFile(
+      path.join(distDir, 'index.html'),
+      'utf8',
+    );
+    assert(contents.includes('.index {'));
+  });
 });
diff --git a/packages/core/integration-tests/test/integration/css-modules-style/index.html b/packages/core/integration-tests/test/integration/css-modules-style/index.html
@@ -0,0 +1,6 @@
+<!DOCTYPE html>
+<style>
+.index {
+  color: red;
+}
+</style>
diff --git a/packages/core/integration-tests/test/integration/css-modules-style/package.json b/packages/core/integration-tests/test/integration/css-modules-style/package.json
@@ -0,0 +1,6 @@
+{
+  "private": true,
+  "@parcel/transformer-css": {
+    "cssModules": true
+  }
+}
diff --git a/packages/core/integration-tests/test/integration/css-modules-style/yarn.lock b/packages/core/integration-tests/test/integration/css-modules-style/yarn.lock
diff --git a/packages/transformers/css/src/CSSTransformer.js b/packages/transformers/css/src/CSSTransformer.js
@@ -53,9 +53,10 @@ export default (new Transformer({
           filename: path.relative(options.projectRoot, asset.filePath),
           code,
           cssModules:
-            config?.cssModules ??
-            (asset.meta.cssModulesCompiled == null &&
-              /\.module\./.test(asset.filePath)),
+            asset.meta.type !== 'tag' &&
+            (config?.cssModules ??
+              (asset.meta.cssModulesCompiled == null &&
+                /\.module\./.test(asset.filePath))),
           analyzeDependencies: asset.meta.hasDependencies !== false,
           sourceMap: !!asset.env.sourceMap,
           drafts: config?.drafts,