Add test for using nearest package.json for sideEffects

parcel-bundler · Apr 6, 2022 · 3b01d23 · 3b01d23
1 parent a8a4f51
commit 3b01d23
Show file tree

Hide file tree

Showing 10 changed files with 55 additions and 0 deletions.
diff --git a/...ion-tests/test/integration/scope-hoisting/es6/side-effects-package-redirect-down/index.js b/...ion-tests/test/integration/scope-hoisting/es6/side-effects-package-redirect-down/index.js
@@ -0,0 +1,3 @@
+import {one} from 'foo/bar'
+
+output = one;
diff --git a/...ope-hoisting/es6/side-effects-package-redirect-down/node_modules/foo/bar/baz/package.json b/...ope-hoisting/es6/side-effects-package-redirect-down/node_modules/foo/bar/baz/package.json
diff --git a/...cope-hoisting/es6/side-effects-package-redirect-down/node_modules/foo/bar/baz/real-bar.js b/...cope-hoisting/es6/side-effects-package-redirect-down/node_modules/foo/bar/baz/real-bar.js
diff --git a/...n/scope-hoisting/es6/side-effects-package-redirect-down/node_modules/foo/bar/package.json b/...n/scope-hoisting/es6/side-effects-package-redirect-down/node_modules/foo/bar/package.json
diff --git a/...ation/scope-hoisting/es6/side-effects-package-redirect-down/node_modules/foo/package.json b/...ation/scope-hoisting/es6/side-effects-package-redirect-down/node_modules/foo/package.json
diff --git a/...ation-tests/test/integration/scope-hoisting/es6/side-effects-package-redirect-up/index.js b/...ation-tests/test/integration/scope-hoisting/es6/side-effects-package-redirect-up/index.js
@@ -0,0 +1,3 @@
+import {one} from 'foo/bar'
+
+output = one;
diff --git a/...ion/scope-hoisting/es6/side-effects-package-redirect-up/node_modules/foo/bar/package.json b/...ion/scope-hoisting/es6/side-effects-package-redirect-up/node_modules/foo/bar/package.json
diff --git a/...gration/scope-hoisting/es6/side-effects-package-redirect-up/node_modules/foo/package.json b/...gration/scope-hoisting/es6/side-effects-package-redirect-up/node_modules/foo/package.json
diff --git a/...egration/scope-hoisting/es6/side-effects-package-redirect-up/node_modules/foo/real-bar.js b/...egration/scope-hoisting/es6/side-effects-package-redirect-up/node_modules/foo/real-bar.js
diff --git a/packages/core/integration-tests/test/scope-hoisting.js b/packages/core/integration-tests/test/scope-hoisting.js
@@ -2264,6 +2264,40 @@ describe('scope hoisting', function () {
       assert.equal(await output, 42);
     });
 
+    describe("considers an asset's closest package.json for sideEffects, not the package through which it found the asset", () => {
+      it('handles redirects up the tree', async () => {
+        let b = await bundle(
+          path.join(
+            __dirname,
+            '/integration/scope-hoisting/es6/side-effects-package-redirect-up/index.js',
+          ),
+        );
+
+        let result = await run(b);
+        assert.strictEqual(result, 1);
+
+        let bar = findAsset(b, 'real-bar.js');
+        assert(bar);
+        assert.strictEqual(bar.sideEffects, false);
+      });
+
+      it('handles redirects down the tree', async () => {
+        let b = await bundle(
+          path.join(
+            __dirname,
+            '/integration/scope-hoisting/es6/side-effects-package-redirect-down/index.js',
+          ),
+        );
+
+        let result = await run(b);
+        assert.strictEqual(result, 1);
+
+        let bar = findAsset(b, 'real-bar.js');
+        assert(bar);
+        assert.strictEqual(bar.sideEffects, false);
+      });
+    });
+
     describe('correctly updates used symbols on changes', () => {
       it('dependency symbols change', async function () {
         let testDir = path.join(