Add lazy/eager cache key to avoid invalid change when switching modes (…

…#9518) * Add lazy/eager cache key to avoid invalid change when switching modes * Update packages/core/core/src/PackagerRunner.js
parcel-bundler · Feb 2, 2024 · 4debc2e · 4debc2e
1 parent 891d105
commit 4debc2e
Show file tree

Hide file tree

Showing 5 changed files with 50 additions and 6 deletions.
diff --git a/packages/core/core/src/PackagerRunner.js b/packages/core/core/src/PackagerRunner.js
@@ -665,7 +665,8 @@ export default class PackagerRunner {
         bundleGraph.getHash(bundle) +
         JSON.stringify(configResults) +
         JSON.stringify(globalInfoResults) +
-        this.options.mode,
+        this.options.mode +
+        (this.options.shouldBuildLazily ? 'lazy' : 'eager'),
     );
   }
 

diff --git a/packages/core/core/src/RequestTracker.js b/packages/core/core/src/RequestTracker.js
@@ -1198,7 +1198,9 @@ export function getWatcherOptions(options: ParcelOptions): WatcherOptions {
 }
 
 function getCacheKey(options) {
-  return `${PARCEL_VERSION}:${JSON.stringify(options.entries)}:${options.mode}`;
+  return `${PARCEL_VERSION}:${JSON.stringify(options.entries)}:${
+    options.mode
+  }:${options.shouldBuildLazily ? 'lazy' : 'eager'}`;
 }
 
 async function loadRequestGraph(options): Async<RequestGraph> {

diff --git a/packages/core/core/src/requests/AssetGraphRequest.js b/packages/core/core/src/requests/AssetGraphRequest.js
@@ -161,7 +161,7 @@ export class AssetGraphBuilder {
       hashString(
         `${PARCEL_VERSION}${name}${JSON.stringify(entries) ?? ''}${
           options.mode
-        }`,
+        }${options.shouldBuildLazily ? 'lazy' : 'eager'}`,
       ) + '-AssetGraph';
 
     this.isSingleChangeRebuild =

diff --git a/packages/core/core/src/requests/BundleGraphRequest.js b/packages/core/core/src/requests/BundleGraphRequest.js
@@ -193,7 +193,7 @@ class BundlerRunner {
       hashString(
         `${PARCEL_VERSION}:BundleGraph:${
           JSON.stringify(options.entries) ?? ''
-        }${options.mode}`,
+        }${options.mode}${options.shouldBuildLazily ? 'lazy' : 'eager'}`,
       ) + '-BundleGraph';
   }
 

diff --git a/packages/core/integration-tests/test/cache.js b/packages/core/integration-tests/test/cache.js
@@ -6200,7 +6200,7 @@ describe('cache', function () {
             loadConfig({config, options}) {
               return DefaultBundler[CONFIG].loadConfig({config, options});
             },
-          
+
             bundle({bundleGraph, config}) {
               DefaultBundler[CONFIG].bundle({bundleGraph, config});
             },
@@ -6218,7 +6218,9 @@ describe('cache', function () {
         hashString(
           `${version}:BundleGraph:${
             JSON.stringify(resolvedOptions.entries) ?? ''
-          }${resolvedOptions.mode}`,
+          }${resolvedOptions.mode}${
+            resolvedOptions.shouldBuildLazily ? 'lazy' : 'eager'
+          }`,
         ) + '-BundleGraph';
 
       assert(
@@ -6788,4 +6790,43 @@ describe('cache', function () {
     let res = await run(build.bundleGraph);
     assert.deepEqual(res, {default: 'foo'});
   });
+
+  it('invalidates correctly when switching from lazy to eager modes', async function () {
+    let overlayFSPackageManager = new NodePackageManager(overlayFS, __dirname);
+    let entry = 'source/index.js';
+    let options = {
+      mode: 'production',
+      defaultTargetOptions: {
+        shouldScopeHoist: false,
+      },
+      packageManager: overlayFSPackageManager,
+      shouldContentHash: false,
+      shouldDisableCache: false,
+      inputFS: overlayFS,
+      cacheDir: path.join(__dirname, '.parcel-cache'),
+    };
+
+    await fsFixture(overlayFS)`
+    source
+      lazy.js:
+
+        export default 'lazy-file';
+      index.js:
+        import('./lazy');
+
+        export default 'index-file';
+    `;
+
+    let lazyBundleGraph = await bundle(entry, {
+      ...options,
+      shouldBuildLazily: true,
+    });
+    assert.equal(lazyBundleGraph.getBundles().length, 1);
+
+    let eagerBundleGraph = await bundle(entry, {
+      ...options,
+      shouldBuildLazily: false,
+    });
+    assert.equal(eagerBundleGraph.getBundles().length, 2);
+  });
 });