Bump minimum version to Node 12, add Node 14 to CI (#5542)

* Bump minimum version to Node 12, add Node 14 to CI * Use native flat(Map) Co-authored-by: Jasper De Moor <jasperdemoor@gmail.com>
parcel-bundler · Dec 30, 2020 · 67aefd8 · 67aefd8
1 parent f62c544
commit 67aefd8
Show file tree

Hide file tree

Showing 92 changed files with 122 additions and 133 deletions.
diff --git a/azure-pipelines-template.yml b/azure-pipelines-template.yml
@@ -4,10 +4,10 @@ jobs:
       vmImage: ${{ parameters.vmImage }}
     strategy:
       matrix:
-        node_10_x:
-          node_version: 10.x
         node_12_x:
           node_version: 12.x
+        node_14_x:
+          node_version: 14.x
       maxParallel: 3
     steps:
       - task: NodeTool@0

diff --git a/package.json b/package.json
@@ -50,7 +50,7 @@
     "sinon": "^7.3.1"
   },
   "engines": {
-    "node": ">= 10.0.0"
+    "node": ">= 12.0.0"
   },
   "husky": {
     "hooks": {

diff --git a/packages/bundlers/default/package.json b/packages/bundlers/default/package.json
@@ -16,7 +16,7 @@
   "main": "lib/DefaultBundler.js",
   "source": "src/DefaultBundler.js",
   "engines": {
-    "node": ">= 10.0.0",
+    "node": ">= 12.0.0",
     "parcel": "^2.0.0-alpha.1.1"
   },
   "dependencies": {

diff --git a/packages/core/cache/package.json b/packages/core/cache/package.json
@@ -16,7 +16,7 @@
   "main": "lib/Cache.js",
   "source": "src/Cache.js",
   "engines": {
-    "node": ">= 10.0.0"
+    "node": ">= 12.0.0"
   },
   "dependencies": {
     "@parcel/logger": "2.0.0-beta.1",

diff --git a/packages/core/codeframe/package.json b/packages/core/codeframe/package.json
@@ -17,7 +17,7 @@
   "main": "lib/codeframe.js",
   "source": "src/codeframe.js",
   "engines": {
-    "node": ">= 10.0.0"
+    "node": ">= 12.0.0"
   },
   "dependencies": {
     "chalk": "^2.4.2",

diff --git a/packages/core/core/package.json b/packages/core/core/package.json
@@ -15,6 +15,9 @@
   },
   "main": "lib/index.js",
   "source": "src/index.js",
+  "engines": {
+    "node": ">= 12.0.0"
+  },
   "scripts": {
     "test": "mocha",
     "test-ci": "mocha"

diff --git a/packages/core/core/src/AssetGraphBuilder.js b/packages/core/core/src/AssetGraphBuilder.js
@@ -35,7 +35,6 @@ import {
   md5FromOrderedObject,
   md5FromString,
   PromiseQueue,
-  flatMap,
 } from '@parcel/utils';
 import ThrowableDiagnostic from '@parcel/diagnostic';
 import AssetGraph from './AssetGraph';
@@ -195,16 +194,17 @@ export default class AssetGraphBuilder extends EventEmitter {
 
     // Skip symbol propagation if no target is using scope hoisting
     // (mainly for faster development builds)
-    let entryDependencies = flatMap(
-      flatMap(this.assetGraph.getNodesConnectedFrom(root), entrySpecifier =>
+    let entryDependencies = this.assetGraph
+      .getNodesConnectedFrom(root)
+      .flatMap(entrySpecifier =>
         this.assetGraph.getNodesConnectedFrom(entrySpecifier),
-      ),
-      entryFile =>
+      )
+      .flatMap(entryFile =>
         this.assetGraph.getNodesConnectedFrom(entryFile).map(dep => {
           invariant(dep.type === 'dependency');
           return dep;
         }),
-    );
+      );
     if (entryDependencies.some(d => d.value.env.scopeHoist)) {
       this.propagateSymbols();
     }

diff --git a/packages/core/core/src/BundleGraph.js b/packages/core/core/src/BundleGraph.js
@@ -23,7 +23,7 @@ import assert from 'assert';
 import invariant from 'assert';
 import crypto from 'crypto';
 import nullthrows from 'nullthrows';
-import {flatMap, objectSortedEntriesDeep} from '@parcel/utils';
+import {objectSortedEntriesDeep} from '@parcel/utils';
 
 import {getBundleGroupId, getPublicId} from './utils';
 import Graph, {ALL_EDGE_TYPES, mapVisitor, type GraphOpts} from './Graph';
@@ -609,22 +609,21 @@ export default class BundleGraph {
     // asynchonously. If any of them appear in our traversal, this asset is
     // referenced.
     let asyncInternalReferencingBundles = new Set(
-      flatMap(
-        this._graph
-          .getNodesConnectedTo(assetNode, 'references')
-          .filter(node => node.type === 'dependency')
-          .map(node => {
-            invariant(node.type === 'dependency');
-            return node;
-          }),
-        dependencyNode =>
+      this._graph
+        .getNodesConnectedTo(assetNode, 'references')
+        .filter(node => node.type === 'dependency')
+        .map(node => {
+          invariant(node.type === 'dependency');
+          return node;
+        })
+        .flatMap(dependencyNode =>
           this._graph
             .getNodesConnectedTo(dependencyNode, 'internal_async')
             .map(node => {
               invariant(node.type === 'bundle');
               return node.value;
             }),
-      ),
+        ),
     );
 
     const bundleHasReference = (bundle: Bundle) => {

diff --git a/packages/core/core/src/Transformation.js b/packages/core/core/src/Transformation.js
@@ -29,7 +29,7 @@ import {
 import logger, {PluginLogger} from '@parcel/logger';
 import {init as initSourcemaps} from '@parcel/source-map';
 import ThrowableDiagnostic, {errorToDiagnostic} from '@parcel/diagnostic';
-import {SOURCEMAP_EXTENSIONS, flatMap} from '@parcel/utils';
+import {SOURCEMAP_EXTENSIONS} from '@parcel/utils';
 
 import ConfigLoader from './ConfigLoader';
 import {createDependency} from './Dependency';
@@ -267,7 +267,7 @@ export default class Transformation {
         [initialAsset],
         pipeline.configs,
         await getInvalidationHash(
-          flatMap(assets, asset => asset.getInvalidations()),
+          assets.flatMap(asset => asset.getInvalidations()),
           this.options,
         ),
       );
@@ -304,7 +304,7 @@ export default class Transformation {
         finalAssets,
         pipeline.configs,
         await getInvalidationHash(
-          flatMap(finalAssets, asset => asset.getInvalidations()),
+          finalAssets.flatMap(asset => asset.getInvalidations()),
           this.options,
         ),
       ),
@@ -320,7 +320,7 @@ export default class Transformation {
           processedFinalAssets,
           pipeline.configs,
           await getInvalidationHash(
-            flatMap(processedFinalAssets, asset => asset.getInvalidations()),
+            processedFinalAssets.flatMap(asset => asset.getInvalidations()),
             this.options,
           ),
         ),

diff --git a/packages/core/core/src/requests/ParcelConfigRequest.js b/packages/core/core/src/requests/ParcelConfigRequest.js
@@ -21,7 +21,6 @@ import {
   validateSchema,
   findAlternativeNodeModules,
   findAlternativeFiles,
-  flatMap,
 } from '@parcel/utils';
 import ThrowableDiagnostic, {
   generateJSONCodeHighlights,
@@ -376,7 +375,7 @@ export async function processConfigChain(
 
     if (errors.length > 0) {
       throw new ThrowableDiagnostic({
-        diagnostic: flatMap(errors, e => e.diagnostics),
+        diagnostic: errors.flatMap(e => e.diagnostics),
       });
     }
   }

diff --git a/packages/core/diagnostic/package.json b/packages/core/diagnostic/package.json
@@ -16,7 +16,7 @@
   "main": "lib/diagnostic.js",
   "source": "src/diagnostic.js",
   "engines": {
-    "node": ">= 10.0.0"
+    "node": ">= 12.0.0"
   },
   "dependencies": {
     "json-source-map": "^0.6.1",

diff --git a/packages/core/fs/package.json b/packages/core/fs/package.json
@@ -17,7 +17,7 @@
   "main": "lib/index.js",
   "source": "src/index.js",
   "engines": {
-    "node": ">= 10.0.0"
+    "node": ">= 12.0.0"
   },
   "dependencies": {
     "@parcel/fs-write-stream-atomic": "2.0.0-beta.1",

diff --git a/packages/core/integration-tests/test/integration/babel-semver-engine/package.json b/packages/core/integration-tests/test/integration/babel-semver-engine/package.json
@@ -11,7 +11,7 @@
     },
     "modern": {
       "engines": {
-        "node": ">= 10.0.0",
+        "node": ">= 12.0.0",
         "yarn": "^1.13.0"
       }
     }

diff --git a/packages/core/logger/package.json b/packages/core/logger/package.json
@@ -17,7 +17,7 @@
   "main": "lib/Logger.js",
   "source": "src/Logger.js",
   "engines": {
-    "node": ">= 10.0.0"
+    "node": ">= 12.0.0"
   },
   "dependencies": {
     "@parcel/diagnostic": "2.0.0-beta.1",

diff --git a/packages/core/markdown-ansi/package.json b/packages/core/markdown-ansi/package.json
@@ -17,7 +17,7 @@
   "main": "lib/markdown-ansi.js",
   "source": "src/markdown-ansi.js",
   "engines": {
-    "node": ">= 10.0.0"
+    "node": ">= 12.0.0"
   },
   "dependencies": {
     "chalk": "^2.4.2"

diff --git a/packages/core/package-manager/package.json b/packages/core/package-manager/package.json
@@ -17,7 +17,7 @@
   "main": "lib/index.js",
   "source": "src/index.js",
   "engines": {
-    "node": ">= 10.0.0"
+    "node": ">= 12.0.0"
   },
   "dependencies": {
     "@parcel/diagnostic": "2.0.0-beta.1",

diff --git a/packages/core/parcel/package.json b/packages/core/parcel/package.json
@@ -18,7 +18,7 @@
   "main": "lib/bin.js",
   "source": "src/bin.js",
   "engines": {
-    "node": ">= 10.0.0"
+    "node": ">= 12.0.0"
   },
   "dependencies": {
     "@parcel/config-default": "2.0.0-beta.1",

diff --git a/packages/core/plugin/package.json b/packages/core/plugin/package.json
@@ -16,7 +16,7 @@
   "main": "lib/PluginAPI.js",
   "source": "src/PluginAPI.js",
   "engines": {
-    "node": ">= 10.0.0"
+    "node": ">= 12.0.0"
   },
   "dependencies": {
     "@parcel/types": "2.0.0-beta.1"

diff --git a/packages/core/register/package.json b/packages/core/register/package.json
@@ -16,7 +16,7 @@
   "main": "lib/register.js",
   "source": "src/register.js",
   "engines": {
-    "node": ">= 10.0.0"
+    "node": ">= 12.0.0"
   },
   "scripts": {
     "run-example": "node ./example/index.js",

diff --git a/packages/core/test-utils/package.json b/packages/core/test-utils/package.json
@@ -10,7 +10,7 @@
   },
   "main": "src/utils.js",
   "engines": {
-    "node": ">= 10.0.0"
+    "node": ">= 12.0.0"
   },
   "dependencies": {
     "@parcel/config-default": "2.0.0-beta.1",

diff --git a/packages/core/utils/package.json b/packages/core/utils/package.json
@@ -17,7 +17,7 @@
   "main": "lib/index.js",
   "source": "src/index.js",
   "engines": {
-    "node": ">= 10.0.0"
+    "node": ">= 12.0.0"
   },
   "dependencies": {
     "@iarna/toml": "^2.2.0",

diff --git a/packages/core/utils/src/collection.js b/packages/core/utils/src/collection.js
@@ -4,26 +4,6 @@ export function unique<T>(array: Array<T>): Array<T> {
   return [...new Set(array)];
 }
 
-export function flat<T>(array: $ReadOnlyArray<$ReadOnlyArray<T>>): Array<T> {
-  let out = [];
-  for (let v of array) {
-    out.push(...v);
-  }
-  return out;
-}
-
-export function flatMap<T, U>(
-  array: Array<T>,
-  projectFn: (T, number, Array<T>) => Array<U>,
-): Array<U> {
-  let out = [];
-
-  for (let i = 0; i < array.length; i++) {
-    out.push(...projectFn(array[i], i, array));
-  }
-  return out;
-}
-
 export function objectSortedEntries(obj: {
   +[string]: mixed,
   ...,

diff --git a/packages/core/utils/src/index.js b/packages/core/utils/src/index.js
@@ -33,8 +33,6 @@ export {findAlternativeNodeModules, findAlternativeFiles} from './alternatives';
 export {blobToBuffer, blobToString} from './blob';
 export {
   unique,
-  flat,
-  flatMap,
   objectSortedEntries,
   objectSortedEntriesDeep,
   setDifference,

diff --git a/packages/core/workers/package.json b/packages/core/workers/package.json
@@ -17,7 +17,7 @@
   "main": "lib/index.js",
   "source": "src/index.js",
   "engines": {
-    "node": ">= 10.0.0"
+    "node": ">= 12.0.0"
   },
   "dependencies": {
     "@parcel/diagnostic": "2.0.0-beta.1",

diff --git a/packages/dev/babel-preset/index.js b/packages/dev/babel-preset/index.js
@@ -5,7 +5,7 @@ module.exports = () => ({
       {
         modules: false,
         targets: {
-          node: 10,
+          node: 12,
         },
       },
     ],

diff --git a/packages/namers/default/package.json b/packages/namers/default/package.json
@@ -16,6 +16,7 @@
   "main": "lib/DefaultNamer.js",
   "source": "src/DefaultNamer.js",
   "engines": {
+    "node": ">= 12.0.0",
     "parcel": "^2.0.0-alpha.1.1"
   },
   "dependencies": {

diff --git a/packages/optimizers/blob-url/package.json b/packages/optimizers/blob-url/package.json
@@ -16,6 +16,7 @@
   "main": "lib/BlobURLOptimizer.js",
   "source": "src/BlobURLOptimizer.js",
   "engines": {
+    "node": ">= 12.0.0",
     "parcel": "^2.0.0-alpha.1.1"
   },
   "dependencies": {

diff --git a/packages/optimizers/cssnano/package.json b/packages/optimizers/cssnano/package.json
@@ -16,6 +16,7 @@
   "main": "lib/CSSNanoOptimizer.js",
   "source": "src/CSSNanoOptimizer.js",
   "engines": {
+    "node": ">= 12.0.0",
     "parcel": "^2.0.0-alpha.1.1"
   },
   "dependencies": {

diff --git a/packages/optimizers/data-url/package.json b/packages/optimizers/data-url/package.json
@@ -16,6 +16,7 @@
   "main": "lib/DataURLOptimizer.js",
   "source": "src/DataURLOptimizer.js",
   "engines": {
+    "node": ">= 12.0.0",
     "parcel": "^2.0.0-alpha.1.1"
   },
   "dependencies": {

diff --git a/packages/optimizers/htmlnano/package.json b/packages/optimizers/htmlnano/package.json
@@ -16,6 +16,7 @@
   "main": "lib/HTMLNanoOptimizer.js",
   "source": "src/HTMLNanoOptimizer.js",
   "engines": {
+    "node": ">= 12.0.0",
     "parcel": "^2.0.0-alpha.1.1"
   },
   "dependencies": {

diff --git a/packages/optimizers/terser/package.json b/packages/optimizers/terser/package.json
@@ -16,7 +16,7 @@
   "main": "lib/TerserOptimizer.js",
   "source": "src/TerserOptimizer.js",
   "engines": {
-    "node": ">= 10.0.0",
+    "node": ">= 12.0.0",
     "parcel": "^2.0.0-alpha.1.1"
   },
   "dependencies": {

diff --git a/packages/packagers/css/package.json b/packages/packagers/css/package.json
@@ -16,7 +16,7 @@
   "main": "lib/CSSPackager.js",
   "source": "src/CSSPackager.js",
   "engines": {
-    "node": ">= 10.0.0",
+    "node": ">= 12.0.0",
     "parcel": "^2.0.0-alpha.1.1"
   },
   "dependencies": {