allow empty string in meta (#2027)

fixes #1714
parcel-bundler · Sep 18, 2018 · 74fe47b · 74fe47b
1 parent 51b5b34
commit 74fe47b
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/packages/core/parcel-bundler/src/assets/HTMLAsset.js b/packages/core/parcel-bundler/src/assets/HTMLAsset.js
@@ -137,7 +137,12 @@ class HTMLAsset extends Asset {
           if (
             !Object.keys(node.attrs).some(attr => {
               let values = META[attr];
-              return values && values.includes(node.attrs[attr]);
+
+              return (
+                values &&
+                values.includes(node.attrs[attr]) &&
+                node.attrs.content !== ''
+              );
             })
           ) {
             return node;

diff --git a/packages/core/parcel-bundler/test/integration/html/index.html b/packages/core/parcel-bundler/test/integration/html/index.html
@@ -1,9 +1,14 @@
 <!doctype html>
 <html>
+
 <head>
   <link rel="stylesheet" href="index.css" />
   <meta property="og:image" content="100x100.png" />
+
+  <!-- fixes https://github.com/parcel-bundler/parcel/issues/1714 -->
+  <meta name="twitter:image" content="" />
 </head>
+
 <body>
   <h1>Hello world</h1>
   <p>Linking to <a href="other.html">another page</a></p>
@@ -15,4 +20,5 @@ <h1>Hello world</h1>
   <i>hello</i> <i>world</i>
   <svg><use href="icons.svg#icon-repo-pull"></use></svg>
 </body>
+
 </html>