don't process external imports (#2380)

parcel-bundler · Dec 11, 2018 · 7a540fc · 7a540fc · dandv · Dec 11, 2018
1 parent 21d6cde
commit 7a540fc
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 0 deletions.
diff --git a/packages/core/parcel-bundler/src/visitors/dependencies.js b/packages/core/parcel-bundler/src/visitors/dependencies.js
@@ -54,6 +54,8 @@ module.exports = {
       types.isStringLiteral(args[0]);
 
     if (isDynamicImport) {
+      if (isURL(args[0].value)) return;
+
       asset.addDependency('_bundle_loader');
       addDependency(asset, args[0], {dynamic: true});
 

diff --git a/packages/core/parcel-bundler/test/integration/dynamic-external/index.js b/packages/core/parcel-bundler/test/integration/dynamic-external/index.js
@@ -0,0 +1,5 @@
+const lodash = import('https://cdnjs.cloudflare.com/ajax/libs/lodash.js/4.17.11/lodash.min.js');
+
+export default function () {
+  return lodash.then(() => _);
+};
diff --git a/packages/core/parcel-bundler/test/javascript.js b/packages/core/parcel-bundler/test/javascript.js
@@ -342,6 +342,25 @@ describe('javascript', function() {
     assert.equal(await output(), 3);
   });
 
+  it('Should not run parcel over external modules', async function() {
+    let b = await bundle(
+      path.join(__dirname, '/integration/dynamic-external/index.js'),
+      {
+        target: 'browser'
+      }
+    );
+
+    await assertBundleTree(b, {
+      name: 'index.js',
+      assets: ['index.js'],
+      childBundles: [
+        {
+          type: 'map'
+        }
+      ]
+    });
+  });
+
   it('should support bundling workers', async function() {
     let b = await bundle(path.join(__dirname, '/integration/workers/index.js'));