Add parenthesis around $parcel$interopDefault call for externals (#…

…7113)
parcel-bundler · Oct 26, 2021 · 8afcd1e · 8afcd1e
1 parent 530e06a
commit 8afcd1e
Show file tree

Hide file tree

Showing 6 changed files with 31 additions and 3 deletions.
diff --git a/packages/core/integration-tests/test/integration/formats/commonjs-external/default-new.js b/packages/core/integration-tests/test/integration/formats/commonjs-external/default-new.js
@@ -0,0 +1,3 @@
+import Foo from "test";
+
+new Foo();
diff --git a/...e/integration-tests/test/integration/formats/commonjs-external/node_modules/test/index.js b/...e/integration-tests/test/integration/formats/commonjs-external/node_modules/test/index.js
diff --git a/...tegration-tests/test/integration/formats/commonjs-external/node_modules/test/package.json b/...tegration-tests/test/integration/formats/commonjs-external/node_modules/test/package.json
diff --git a/packages/core/integration-tests/test/integration/formats/commonjs-external/package.json b/packages/core/integration-tests/test/integration/formats/commonjs-external/package.json
@@ -6,6 +6,7 @@
     "node": ">= 10.x"
   },
   "dependencies": {
-    "lodash": "*"
+    "lodash": "*",
+    "test": "*"
   }
 }
diff --git a/packages/core/integration-tests/test/output-formats.js b/packages/core/integration-tests/test/output-formats.js
@@ -168,6 +168,19 @@ describe('output formats', function() {
       assert.equal((await run(b)).bar, 3);
     });
 
+    it('should support commonjs output with external modules (default import new call)', async function() {
+      let b = await bundle(
+        path.join(
+          __dirname,
+          '/integration/formats/commonjs-external/default-new.js',
+        ),
+      );
+
+      let dist = await outputFS.readFile(b.getBundles()[0].filePath, 'utf8');
+      assert(dist.includes('$parcel$interopDefault'));
+      await run(b);
+    });
+
     it('should support commonjs output with external modules (multiple specifiers)', async function() {
       let b = await bundle(
         path.join(
@@ -178,7 +191,7 @@ describe('output formats', function() {
 
       let dist = await outputFS.readFile(b.getBundles()[0].filePath, 'utf8');
       assert(dist.includes('= require("lodash")'));
-      assert(dist.includes('= $parcel$interopDefault('));
+      assert(dist.includes('= ($parcel$interopDefault('));
       assert(/var {add: \s*\$.+?\$add\s*} = lodash/);
       assert.equal((await run(b)).bar, 6);
     });

diff --git a/packages/packagers/js/src/ScopeHoistingPackager.js b/packages/packagers/js/src/ScopeHoistingPackager.js
@@ -580,7 +580,7 @@ ${code}
               if (imported === '*') {
                 replacement = renamed;
               } else if (imported === 'default') {
-                replacement = `$parcel$interopDefault(${renamed})`;
+                replacement = `($parcel$interopDefault(${renamed}))`;
                 this.usedHelpers.add('$parcel$interopDefault');
               } else {
                 replacement = this.getPropertyAccess(renamed, imported);