Feature: support href attribute in <image /> in collecting dependenci…

…es in HTMLTransformer (#7482)
parcel-bundler · Dec 25, 2021 · af76afc · af76afc
1 parent 8823770
commit af76afc
Show file tree

Hide file tree

Showing 4 changed files with 31 additions and 1 deletion.
diff --git a/packages/core/integration-tests/test/html.js b/packages/core/integration-tests/test/html.js
@@ -965,6 +965,23 @@ describe('html', function () {
     ]);
   });
 
+  it("should support href attribute in <image /> in HTMLTransformer's collectDependencies", async function () {
+    let b = await bundle(
+      path.join(__dirname, '/integration/html-image-href-attr/index.html'),
+    );
+
+    assertBundles(b, [
+      {
+        name: 'index.html',
+        assets: ['index.html'],
+      },
+      {
+        type: 'png',
+        assets: ['100x100.png'],
+      },
+    ]);
+  });
+
   // Based on https://developer.mozilla.org/en-US/docs/Web/SVG/Element/script
   it('should bundle scripts inside svg', async function () {
     let b = await bundle(

diff --git a/packages/core/integration-tests/test/integration/html-image-href-attr/100x100.png b/packages/core/integration-tests/test/integration/html-image-href-attr/100x100.png
diff --git a/packages/core/integration-tests/test/integration/html-image-href-attr/index.html b/packages/core/integration-tests/test/integration/html-image-href-attr/index.html
@@ -0,0 +1,13 @@
+<!doctype html>
+<html>
+
+<head>
+</head>
+
+<body>
+  <svg>
+    <image href="./100x100.png" />
+  </svg>
+</body>
+
+</html>
diff --git a/packages/transformers/html/src/dependencies.js b/packages/transformers/html/src/dependencies.js
@@ -18,7 +18,7 @@ const ATTRS = {
     'amp-img',
   ],
   // Using href with <script> is described here: https://developer.mozilla.org/en-US/docs/Web/SVG/Element/script
-  href: ['link', 'a', 'use', 'script'],
+  href: ['link', 'a', 'use', 'script', 'image'],
   srcset: ['img', 'source'],
   imagesrcset: ['link'],
   poster: ['video'],