Handle empty html files (#2621)

parcel-bundler · Feb 7, 2019 · bdef68b · bdef68b
1 parent 4c5993f
commit bdef68b
Show file tree

Hide file tree

Showing 3 changed files with 54 additions and 40 deletions.
diff --git a/packages/core/integration-tests/test/html.js b/packages/core/integration-tests/test/html.js
@@ -296,6 +296,18 @@ describe('html', function() {
     assert(html.includes('Other page'));
   });
 
+  it('should work with an empty html file', async function() {
+    let inputFile = path.join(__dirname, '/integration/html-empty/index.html');
+    await bundle(inputFile, {
+      minify: false
+    });
+
+    let outputFile = path.join(__dirname, '/dist/index.html');
+
+    let html = await fs.readFile(outputFile, 'utf8');
+    assert.equal(html.length, 0);
+  });
+
   it('should read .htmlnanorc and minify HTML in production mode', async function() {
     await bundle(
       path.join(__dirname, '/integration/htmlnano-config/index.html'),

diff --git a/packages/core/integration-tests/test/integration/html-empty/index.html b/packages/core/integration-tests/test/integration/html-empty/index.html
diff --git a/packages/core/parcel-bundler/src/assets/HTMLAsset.js b/packages/core/parcel-bundler/src/assets/HTMLAsset.js
@@ -204,59 +204,61 @@ class HTMLAsset extends Asset {
   async generate() {
     // Extract inline <script> and <style> tags for processing.
     let parts = [];
-    this.ast.walk(node => {
-      if (node.tag === 'script' || node.tag === 'style') {
-        let value = node.content && node.content.join('').trim();
-        if (value) {
-          let type;
+    if (this.ast) {
+      this.ast.walk(node => {
+        if (node.tag === 'script' || node.tag === 'style') {
+          let value = node.content && node.content.join('').trim();
+          if (value) {
+            let type;
 
-          if (node.tag === 'style') {
-            if (node.attrs && node.attrs.type) {
-              type = node.attrs.type.split('/')[1];
-            } else {
-              type = 'css';
-            }
-          } else if (node.attrs && node.attrs.type) {
-            // Skip JSON
-            if (SCRIPT_TYPES[node.attrs.type] === false) {
-              return node;
-            }
+            if (node.tag === 'style') {
+              if (node.attrs && node.attrs.type) {
+                type = node.attrs.type.split('/')[1];
+              } else {
+                type = 'css';
+              }
+            } else if (node.attrs && node.attrs.type) {
+              // Skip JSON
+              if (SCRIPT_TYPES[node.attrs.type] === false) {
+                return node;
+              }
 
-            if (SCRIPT_TYPES[node.attrs.type]) {
-              type = SCRIPT_TYPES[node.attrs.type];
+              if (SCRIPT_TYPES[node.attrs.type]) {
+                type = SCRIPT_TYPES[node.attrs.type];
+              } else {
+                type = node.attrs.type.split('/')[1];
+              }
             } else {
-              type = node.attrs.type.split('/')[1];
+              type = 'js';
             }
-          } else {
-            type = 'js';
+
+            parts.push({
+              type,
+              value,
+              inlineHTML: true,
+              meta: {
+                type: 'tag',
+                node
+              }
+            });
           }
+        }
 
+        // Process inline style attributes.
+        if (node.attrs && node.attrs.style) {
           parts.push({
-            type,
-            value,
-            inlineHTML: true,
+            type: 'css',
+            value: node.attrs.style,
             meta: {
-              type: 'tag',
+              type: 'attr',
               node
             }
           });
         }
-      }
 
-      // Process inline style attributes.
-      if (node.attrs && node.attrs.style) {
-        parts.push({
-          type: 'css',
-          value: node.attrs.style,
-          meta: {
-            type: 'attr',
-            node
-          }
-        });
-      }
-
-      return node;
-    });
+        return node;
+      });
+    }
 
     return parts;
   }