Fix sourceMappingURL for bundles with multiple entry points

parcel-bundler · Feb 14, 2019 · c0eff27 · c0eff27
1 parent a2e38f9
commit c0eff27
Show file tree

Hide file tree

Showing 6 changed files with 40 additions and 1 deletion.
diff --git a/...gration-tests/test/integration/sourcemap-sourcemappingurl-multiple-entrypoints/a/index.js b/...gration-tests/test/integration/sourcemap-sourcemappingurl-multiple-entrypoints/a/index.js
@@ -0,0 +1 @@
+console.log('hello1');
diff --git a/...gration-tests/test/integration/sourcemap-sourcemappingurl-multiple-entrypoints/b/index.js b/...gration-tests/test/integration/sourcemap-sourcemappingurl-multiple-entrypoints/b/index.js
@@ -0,0 +1 @@
+console.log('hello2');
diff --git a/...gration-tests/test/integration/sourcemap-sourcemappingurl-multiple-entrypoints/index.html b/...gration-tests/test/integration/sourcemap-sourcemappingurl-multiple-entrypoints/index.html
@@ -0,0 +1,6 @@
+<html>
+  <head>
+    <script src='./a/index.js'> </script>
+    <script src='./b/index.js'> </script>
+  </head>
+</html>>
diff --git a/packages/core/integration-tests/test/integration/sourcemap-sourcemappingurl/index.js b/packages/core/integration-tests/test/integration/sourcemap-sourcemappingurl/index.js
@@ -0,0 +1 @@
+console.log('hello');
diff --git a/packages/core/integration-tests/test/sourcemaps.js b/packages/core/integration-tests/test/sourcemaps.js
@@ -314,4 +314,34 @@ describe('sourcemaps', function() {
     );
     mapValidator(jsOutput, map);
   });
+
+  it('should create correct sourceMappingURL', async function() {
+    const b = await bundle(
+      path.join(__dirname, '/integration/sourcemap-sourcemappingurl/index.js')
+    );
+
+    const jsOutput = await fs.readFile(b.name, 'utf8');
+    assert(jsOutput.includes('//# sourceMappingURL=/index.js.map'));
+  });
+
+  it('should create correct sourceMappingURL with multiple entrypoints', async function() {
+    const b = await bundle([
+      path.join(
+        __dirname,
+        '/integration/sourcemap-sourcemappingurl-multiple-entrypoints/a/index.js'
+      ),
+      path.join(
+        __dirname,
+        '/integration/sourcemap-sourcemappingurl-multiple-entrypoints/b/index.js'
+      )
+    ]);
+
+    const bundle1 = [...b.childBundles][0];
+    const bundle2 = [...b.childBundles][1];
+    const jsOutput1 = await fs.readFile(bundle1.name, 'utf8');
+    const jsOutput2 = await fs.readFile(bundle2.name, 'utf8');
+
+    assert(jsOutput1.includes('//# sourceMappingURL=/a/index.js.map'));
+    assert(jsOutput2.includes('//# sourceMappingURL=/b/index.js.map'));
+  });
 });
diff --git a/packages/core/parcel-bundler/src/packagers/JSPackager.js b/packages/core/parcel-bundler/src/packagers/JSPackager.js
@@ -239,7 +239,7 @@ class JSPackager extends Packager {
       if (mapBundle) {
         let mapUrl = urlJoin(
           this.options.publicURL,
-          path.basename(mapBundle.name)
+          path.relative(this.options.outDir, mapBundle.name)
         );
         await this.write(`\n//# sourceMappingURL=${mapUrl}`);
       }