Fix loading index.html in dev server when packager/optimizer changes …

…bundle type
parcel-bundler · Jan 5, 2022 · cc8ba78 · cc8ba78
1 parent 5a80fbe
commit cc8ba78
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 10 deletions.
diff --git a/packages/core/core/src/public/Bundle.js b/packages/core/core/src/public/Bundle.js
@@ -314,6 +314,10 @@ export class PackagedBundle extends NamedBundle implements IPackagedBundle {
     );
   }
 
+  get type(): string {
+    return nullthrows(this.#bundleInfo).type;
+  }
+
   get stats(): Stats {
     return nullthrows(this.#bundleInfo).stats;
   }

diff --git a/packages/core/core/src/requests/WriteBundleRequest.js b/packages/core/core/src/requests/WriteBundleRequest.js
@@ -181,6 +181,7 @@ async function run({input, options, api}: RunInput) {
 
   let res = {
     filePath,
+    type: info.type,
     stats: {
       size,
       time: info.time ?? 0,

diff --git a/packages/core/core/src/requests/WriteBundlesRequest.js b/packages/core/core/src/requests/WriteBundlesRequest.js
@@ -71,6 +71,7 @@ async function run({input, api, farm, options}: RunInput) {
       let name = nullthrows(bundle.name).replace(bundle.hashReference, hash);
       res.set(bundle.id, {
         filePath: joinProjectPath(bundle.target.distDir, name),
+        type: bundle.type, // FIXME: this is wrong if the packager changes the type...
         stats: {
           time: 0,
           size: 0,

diff --git a/packages/core/core/src/types.js b/packages/core/core/src/types.js
@@ -500,6 +500,7 @@ export type BundleGroupNode = {|
 
 export type PackagedBundleInfo = {|
   filePath: ProjectPath,
+  type: string,
   stats: Stats,
 |};
 

diff --git a/packages/reporters/dev-server/src/Server.js b/packages/reporters/dev-server/src/Server.js
@@ -161,16 +161,19 @@ export default class Server {
   sendIndex(req: Request, res: Response) {
     if (this.bundleGraph) {
       // If the main asset is an HTML file, serve it
-      let htmlBundleFilePaths = [];
-      this.bundleGraph.traverseBundles(bundle => {
-        if (bundle.type === 'html' && bundle.bundleBehavior !== 'inline') {
-          htmlBundleFilePaths.push(bundle.filePath);
-        }
-      });
-
-      htmlBundleFilePaths = htmlBundleFilePaths.map(p => {
-        return `/${relativePath(this.options.distDir, p, false)}`;
-      });
+      let htmlBundleFilePaths = this.bundleGraph
+        .getBundles()
+        .filter(
+          bundle =>
+            bundle.type === 'html' && bundle.bundleBehavior !== 'inline',
+        )
+        .map(bundle => {
+          return `/${relativePath(
+            this.options.distDir,
+            bundle.filePath,
+            false,
+          )}`;
+        });
 
       let indexFilePath = null;
       if (htmlBundleFilePaths.length === 1) {