fix: Treat webmanifest as an entry module (#2254)

parcel-bundler · Nov 8, 2018 · d8ddcaf · d8ddcaf
1 parent 9136cdc
commit d8ddcaf
Show file tree

Hide file tree

Showing 5 changed files with 47 additions and 1 deletion.
diff --git a/packages/core/parcel-bundler/src/assets/HTMLAsset.js b/packages/core/parcel-bundler/src/assets/HTMLAsset.js
@@ -153,6 +153,20 @@ class HTMLAsset extends Asset {
           }
         }
 
+        if (
+          node.tag === 'link' &&
+          node.attrs.rel === 'manifest' &&
+          node.attrs.href
+        ) {
+          node.attrs.href = this.getAttrDepHandler('href').call(
+            this,
+            node.attrs.href,
+            {entry: true}
+          );
+          this.isAstDirty = true;
+          return node;
+        }
+
         for (let attr in node.attrs) {
           let elements = ATTRS[attr];
           // Check for virtual paths

diff --git a/packages/core/parcel-bundler/test/html.js b/packages/core/parcel-bundler/test/html.js
@@ -591,6 +591,26 @@ describe('html', function() {
     });
   });
 
+  it("should treat webmanifest as an entry module so it doesn't get content hashed", async function() {
+    const b = await bundle(
+      path.join(__dirname, '/integration/html-manifest/index.html')
+    );
+
+    await assertBundleTree(b, {
+      name: 'index.html',
+      assets: ['index.html'],
+      childBundles: [
+        {
+          type: 'webmanifest',
+          assets: ['manifest.webmanifest']
+        }
+      ]
+    });
+
+    const html = await fs.readFile(path.join(__dirname, '/dist/index.html'));
+    assert(html.includes('<link rel="manifest" href="/manifest.webmanifest">'));
+  });
+
   it('should bundle svg files correctly', async function() {
     let b = await bundle(
       path.join(__dirname, '/integration/html-svg/index.html')

diff --git a/packages/core/parcel-bundler/test/integration/html-manifest/index.html b/packages/core/parcel-bundler/test/integration/html-manifest/index.html
@@ -0,0 +1,8 @@
+<!doctype html>
+<html>
+<head>
+  <link rel="manifest" href="manifest.webmanifest" />
+</head>
+<body>
+</body>
+</html>
diff --git a/packages/core/parcel-bundler/test/integration/html-manifest/manifest.webmanifest b/packages/core/parcel-bundler/test/integration/html-manifest/manifest.webmanifest
@@ -0,0 +1,3 @@
+{
+
+}
diff --git a/packages/core/workers/test/mocha.opts b/packages/core/workers/test/mocha.opts
@@ -1,2 +1,3 @@
 --require @parcel/babel-register
---exit
+--exit
+--timeout 20s