Skip to content

Commit

Permalink
Drop Node 12 in tests and add Node 16 (#7935)
Browse files Browse the repository at this point in the history
  • Loading branch information
mischnic committed Apr 26, 2022
1 parent 7c6469a commit ffcc995
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:
name: Unit tests (${{matrix.os}}, Node ${{matrix.node}})
strategy:
matrix:
node: [12, 14]
node: [14, 16]
os: [ubuntu-latest, macos-latest, windows-latest]
runs-on: ${{matrix.os}}
steps:
Expand All @@ -64,7 +64,7 @@ jobs:
name: Integration tests (${{matrix.os}}, Node ${{matrix.node}})
strategy:
matrix:
node: [12, 14]
node: [14, 16]
os: [ubuntu-latest, macos-latest, windows-latest]
runs-on: ${{matrix.os}}
steps:
Expand Down
3 changes: 2 additions & 1 deletion packages/core/test-utils/src/utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -988,7 +988,8 @@ export async function runESM(
identifier: `${normalizeSeparators(
path.relative(baseDir, filename),
)}?id=${id}`,
importModuleDynamically: entry,
importModuleDynamically: (specifier, referrer) =>
entry(specifier, referrer),
context,
initializeImportMeta(meta) {
meta.url = `http://localhost/${path.basename(filename)}`;
Expand Down

0 comments on commit ffcc995

Please sign in to comment.