Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:Cannot read property js of null #1248

Closed
wants to merge 1 commit into from
Closed

fix:Cannot read property js of null #1248

wants to merge 1 commit into from

Conversation

80245089
Copy link

@80245089 80245089 commented Apr 25, 2018

image

I modify the method addAsset in JSPackager.js the source is
if (asset.generated == null) {
return;
}

Close #1158 #1227

@codecov-io
Copy link

Codecov Report

Merging #1248 into master will decrease coverage by 0.39%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1248     +/-   ##
=========================================
- Coverage   87.38%   86.98%   -0.4%     
=========================================
  Files          77       77             
  Lines        4105     4034     -71     
=========================================
- Hits         3587     3509     -78     
- Misses        518      525      +7
Impacted Files Coverage Δ
src/packagers/JSPackager.js 87.85% <50%> (-0.73%) ⬇️
src/utils/promisify.js 88.88% <0%> (-11.12%) ⬇️
src/visitors/fs.js 79.86% <0%> (-6.25%) ⬇️
src/utils/installPackage.js 89.65% <0%> (-3.75%) ⬇️
src/utils/pipeSpawn.js 92.3% <0%> (-3.15%) ⬇️
src/assets/JSAsset.js 90.9% <0%> (-3.04%) ⬇️
src/assets/GraphqlAsset.js 100% <0%> (ø) ⬆️
src/transforms/babel.js 88.55% <0%> (+0.49%) ⬆️
src/Logger.js 96.84% <0%> (+1.05%) ⬆️
src/utils/PromiseQueue.js 94.23% <0%> (+3.44%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11a7882...55be029. Read the comment docs.

@DeMoorJasper
Copy link
Member

DeMoorJasper commented Apr 28, 2018

@80245089 would be nice to have a minimal reproduction test case for this as well :)

@devongovett
Copy link
Member

Yeah I'd rather solve the actual problem rather than patch fixing.asset.generated should never be null.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants