Support sideEffect: false with CommonJS #1770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devongovett
reviewed
Jul 21, 2018
| } | ||
|
|
||
| asset.cacheData.imports['$require$' + source] = [source, '*']; |
There was a problem hiding this comment.
This could potentially conflict with a real import, right? e.g. import $require$foo from './foo'
There was a problem hiding this comment.
hmm, in imports we would use $id$import$$require$foo as key :
asset.cacheData.imports = {
"$require$foo": ['foo', '*'],
"$id$import$$require$foo": ['./foo', 'default']
}or is there another place where it would conflict?
devongovett
approved these changes
Jul 22, 2018
|
Awesome work, thank you for your efforts. |
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the fixes for #1699.
We currently can't
requirea module withsideEffects: false. This PR adds a$require$NAMEentry tocacheData.importsso we can treatrequirelike it is a wildcard import.