Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add debugger flag for non production builds in Elm #2225

Merged
merged 3 commits into from Nov 8, 2018
Merged

add debugger flag for non production builds in Elm #2225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2f83f6f
add debugger flag for non production builds in Elm
Maxim-Filimonov Oct 31, 2018
2e40867
satisfy linter
Maxim-Filimonov Nov 1, 2018
e9ae0c9
Merge branch 'master' into elm-debug-support-monorepo
DeMoorJasper Nov 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/core/parcel-bundler/src/assets/ElmAsset.js
View file
Open in desktop
Expand Up @@ -40,6 +40,7 @@ class ElmAsset extends Asset {
await this.getConfig(['elm.json'], {load: false});
}

options.debug = !this.options.production;
if (this.options.minify) {
options.optimize = true;
}
Expand Down
17 changes: 17 additions & 0 deletions packages/core/parcel-bundler/test/elm.js
View file
Open in desktop
Expand Up @@ -14,6 +14,23 @@ describe('elm', function() {
let output = await run(b);
assert.equal(typeof output().Elm.Main.init, 'function');
});
it('should produce a elm bundle with debugger', async function() {
let b = await bundle(__dirname + '/integration/elm/index.js');

await run(b);
let js = await fs.readFile(__dirname + '/dist/index.js', 'utf8');
assert(js.includes('elm$browser$Debugger'));
});

it('should remove debugger in production', async function() {
let b = await bundle(__dirname + '/integration/elm/index.js', {
production: true
});

await run(b);
let js = await fs.readFile(__dirname + '/dist/index.js', 'utf8');
assert(!js.includes('elm$browser$Debugger'));
});

it('should minify Elm in production mode', async function() {
let b = await bundle(__dirname + '/integration/elm/index.js', {
Expand Down