Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix absolute path importing in sass #2432

Merged
merged 11 commits into from Feb 17, 2019
Merged

Fix absolute path importing in sass #2432

merged 11 commits into from Feb 17, 2019

Conversation

DeMoorJasper
Copy link
Member

@DeMoorJasper DeMoorJasper commented Dec 18, 2018

↪️ Pull Request

For some reason the sass compiler adds file:// to absolute paths, this PR removes that as file paths should be resolved by parcel...

Fixes #2431

Copy link
Member

@devongovett devongovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs a test

packages/core/parcel-bundler/src/assets/SASSAsset.js Outdated Show resolved Hide resolved
@evanleck
Copy link

evanleck commented Jan 8, 2019

Sorry to pester but is there any chance of this getting merged? I opened issue #2431 that this fixes.

@devongovett devongovett merged commit 31bd420 into master Feb 17, 2019
@devongovett devongovett deleted the fix-sass-absolute branch February 17, 2019 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sass "Absolute Path" Module Resolution Fails
4 participants