Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary return await #2705

Merged
merged 1 commit into from Mar 1, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/core/parcel-bundler/src/Asset.js
Expand Up @@ -159,7 +159,7 @@ class Asset {
return conf;
}

return await config.load(opts.path || this.name, filenames);
return config.load(opts.path || this.name, filenames);
}

return null;
Expand All @@ -170,7 +170,7 @@ class Asset {
}

async load() {
return await fs.readFile(this.name, this.encoding);
return fs.readFile(this.name, this.encoding);
}

parse() {
Expand Down
4 changes: 2 additions & 2 deletions packages/core/parcel-bundler/src/Bundler.js
Expand Up @@ -490,7 +490,7 @@ class Bundler extends EventEmitter {
this.options.autoinstall &&
install
) {
return await this.installDep(asset, dep);
return this.installDep(asset, dep);
}

err.message = `Cannot resolve dependency '${dep.name}'`;
Expand Down Expand Up @@ -521,7 +521,7 @@ class Bundler extends EventEmitter {
}
}

return await this.resolveDep(asset, dep, false);
return this.resolveDep(asset, dep, false);
}

async throwDepError(asset, dep, err) {
Expand Down
2 changes: 1 addition & 1 deletion packages/core/parcel-bundler/src/Resolver.js
Expand Up @@ -251,7 +251,7 @@ class Resolver {
}

// Fall back to an index file inside the directory.
return await this.loadAsFile(path.join(dir, 'index'), extensions, pkg);
return this.loadAsFile(path.join(dir, 'index'), extensions, pkg);
}

async readPackage(dir) {
Expand Down
2 changes: 1 addition & 1 deletion packages/core/parcel-bundler/src/SourceMap.js
Expand Up @@ -35,7 +35,7 @@ class SourceMap {
}
map = typeof map === 'string' ? JSON.parse(map) : map;
if (map.sourceRoot) delete map.sourceRoot;
return await new SourceMapConsumer(map);
return new SourceMapConsumer(map);
}

async addMap(map, lineOffset = 0, columnOffset = 0) {
Expand Down
2 changes: 1 addition & 1 deletion packages/core/parcel-bundler/src/assets/GLSLAsset.js
Expand Up @@ -37,7 +37,7 @@ class GLSLAsset extends Asset {
}
});

return await promisify(depper.inline.bind(depper))(this.contents, cwd);
return promisify(depper.inline.bind(depper))(this.contents, cwd);
}

collectDependencies() {
Expand Down
2 changes: 1 addition & 1 deletion packages/core/parcel-bundler/src/assets/LESSAsset.js
Expand Up @@ -23,7 +23,7 @@ class LESSAsset extends Asset {
opts.filename = this.name;
opts.plugins = (opts.plugins || []).concat(urlPlugin(this));

return await render(code, opts);
return render(code, opts);
}

collectDependencies() {
Expand Down
2 changes: 1 addition & 1 deletion packages/core/parcel-bundler/src/assets/RawAsset.js
Expand Up @@ -27,7 +27,7 @@ class RawAsset extends Asset {
}

async generateHash() {
return await md5.file(this.name);
return md5.file(this.name);
}
}

Expand Down
2 changes: 1 addition & 1 deletion packages/core/parcel-bundler/src/assets/SASSAsset.js
Expand Up @@ -90,7 +90,7 @@ async function getSassRuntime(searchPath) {
return await localRequire('node-sass', searchPath, true);
} catch (e) {
// If node-sass is not used locally, install dart-sass, as this causes no freezing issues
return await localRequire('sass', searchPath);
return localRequire('sass', searchPath);
}
}

Expand Down
4 changes: 2 additions & 2 deletions packages/core/parcel-bundler/src/transforms/babel/babelrc.js
Expand Up @@ -58,7 +58,7 @@ async function getBabelRc(asset, isSource) {

// If this asset is not in node_modules, always use the .babelrc
if (isSource) {
return await findBabelRc(asset);
return findBabelRc(asset);
}

// Otherwise, don't load .babelrc for node_modules.
Expand Down Expand Up @@ -266,7 +266,7 @@ async function installPlugins(asset, babelrc) {
let plugins = (babelrc.plugins || []).map(p =>
resolveModule('plugin', getPluginName(p), asset.name)
);
return await Promise.all([...presets, ...plugins]);
return Promise.all([...presets, ...plugins]);
}

async function resolveModule(type, name, path) {
Expand Down
4 changes: 2 additions & 2 deletions packages/core/parcel-bundler/src/utils/loadPlugins.js
Expand Up @@ -2,8 +2,8 @@ const localRequire = require('./localRequire');

module.exports = async function loadPlugins(plugins, relative) {
if (Array.isArray(plugins)) {
return await Promise.all(
plugins.map(async p => await loadPlugin(p, relative)).filter(Boolean)
return Promise.all(
plugins.map(async p => loadPlugin(p, relative)).filter(Boolean)
);
} else if (typeof plugins === 'object') {
let mapPlugins = await Promise.all(
Expand Down
2 changes: 1 addition & 1 deletion packages/core/parcel-bundler/src/utils/localRequire.js
Expand Up @@ -22,7 +22,7 @@ async function localResolve(name, path, triedInstall = false) {
if (e.code === 'MODULE_NOT_FOUND' && !triedInstall) {
const packageName = getModuleParts(name)[0];
await installPackage(packageName, path);
return await localResolve(name, path, true);
return localResolve(name, path, true);
}
throw e;
}
Expand Down