Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eslint: enable no-return-await #2707

Merged
merged 1 commit into from Mar 5, 2019
Merged

eslint: enable no-return-await #2707

merged 1 commit into from Mar 5, 2019

Commits on Mar 1, 2019

  1. eslint: enable no-return-await 

    This sets violations of the `no-return-await` to `error`. `return await` is redundant as values returned from an async function are effectively wrapped in a `Promise.resolve`, and awaiting another promise in addition to this will defer resolution another microtick.

[eslint is good enough to detect the valid use case of `return await` in a `try`/`catch`](https://eslint.org/docs/rules/no-return-await). We also get clever with a short circuiting `||` in `Resolver` so I disabled it there, but we should probably rewrite it to be clearer in the future.

Test Plan: `yarn && yarn lint && yarn test`
    @wbinnssmith
    wbinnssmith committed Mar 1, 2019
    Copy the full SHA
    7dc88fb View commit details
    Browse the repository at this point in the history