Cherry-pick CSS Sourcemaps #2917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) * Defer throwing asset errors until after dependencies are handled. This allows compiled langauges like Elm that handle their own dependency compilation to set up watchers for dependencies so that hot-reload continues to work due to errors in new depdenencies. Fixes #2147. * Fix Elm error generation. I'm not entirely sure why this fix is necessary, but without it a compile error during a rebuild results in Parcel printing "Unknown error" instead of anything useful. Since we are intecepting the error though, we can also remove redundant stack information. * Add test for tracking dependencies on error * revert hmr-runtime changes * Transform all errors in Pipeline.process. This prevents error data from being lost when Pipeline is run via `WorkerFarm`. * Separate error-depenency test input from basic Elm tests. * Update ElmAsset.js
wbinnssmith
requested review from
DeMoorJasper,
devongovett,
padmaia and
mischnic
|
Perhaps it would be a better idea to try and merge master into v2 instead? (although this is getting pretty hard as there's a diff of a couple hundred commits) |
I mostly want the tests, but I suppose everything could just be copied over. Merging master into v2 is a pretty big undertaking that I probably won't have much context on 😄 I'd definitely be on board with that but I'm not the best to do so. |
DeMoorJasper
approved these changes
Apr 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This forward-ports @mischnic's work on css sourcemaps into the v2 branch.
Note that this is a cherry-pick of #2489 as well as two other commits necessary for existing tests to pass. The css integration tests continue to be skipped, and it's possible we're missing more code that we don't exercise yet. A full merge of master back into v2 should resolve that.