Fix: set pragmafrag for jsx in v2 #3617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preact 10 now has support for fragments as well, could you add that as well (with autodetection just as // preact
['@babel/plugin-transform-react-jsx', { pragma: 'h', pragmaFrag: 'Fragment' }], |
|
I guess you mean this. :) |
mischnic
approved these changes
Oct 11, 2019
|
Would be great to add a test for this, if you don't mind making a followup PR. 😄 |
|
Sure! Hang on for a bit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
I discovered the issue while tracking down #3446 here: #3446 (comment).
AFAIK, the issue has been solved in v1 with #2486, so I decided to port it to v2 as is.
✔️ PR Todo