Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sourceMappingURL for bundles with multiple entry points [CSS] #3938

Closed
wants to merge 8 commits into from

Conversation

powerc9000
Copy link

↪️ Pull Request

Fixes css source map being at the incorrect URL same as #2645
This is to move a PR #2867 into V2
Related issue #2851

💻 Examples

Given the followong CLI command

parcel build src/a/style.css src/b/style.css

The following files are produced

dist/a/style.css /*# sourceMappingURL=/style.css.map */
dist/b/style.css /*# sourceMappingURL=/style.css.map */

The sourcemap URLs are incorrect they should be /a/style.css.map and /b/style.css.map.

With the fix in place we instead get:

dist/a/style.css /*# sourceMappingURL=/a/style.css.map */
dist/b/style.css /*# sourceMappingURL=/b/style.css.map */

✔️ PR Todo

  • [ x] Added/updated unit tests for this change
  • [ x] Filled out test instructions (In case there aren't any unit tests)
  • [x ] Included links to related issues/PRs

@height
Copy link

height bot commented Dec 23, 2019

This pull request has been linked to T-190.

@height
Copy link

height bot commented Dec 23, 2019

This pull request has been linked to T-246.

@height
Copy link

height bot commented Dec 23, 2019

This pull request has been linked to T-1.

@height
Copy link

height bot commented Dec 23, 2019

This pull request has been linked to T-208.

@height
Copy link

height bot commented Dec 23, 2019

This pull request has been linked to T-88.

@height
Copy link

height bot commented Dec 23, 2019

This pull request has been linked to T-249.

@height
Copy link

height bot commented Dec 23, 2019

This pull request has been linked to T-227.

@height
Copy link

height bot commented Dec 23, 2019

This pull request has been linked to T-233.

@height
Copy link

height bot commented Dec 23, 2019

This pull request has been linked to T-74.

@height
Copy link

height bot commented Dec 23, 2019

This pull request has been linked to T-220.

@height
Copy link

height bot commented Dec 23, 2019

This pull request has been linked to T-228.

@height
Copy link

height bot commented Dec 23, 2019

This pull request has been linked to T-206.

@height
Copy link

height bot commented Dec 23, 2019

This pull request has been linked to T-163.

@height
Copy link

height bot commented Dec 23, 2019

This pull request has been linked to T-185.

@height
Copy link

height bot commented Dec 23, 2019

This pull request has been linked to T-16.

@height
Copy link

height bot commented Dec 23, 2019

This pull request has been linked to T-93.

@height
Copy link

height bot commented Dec 23, 2019

This pull request has been linked to T-177.

@height
Copy link

height bot commented Dec 23, 2019

This pull request has been linked to T-234.

Copy link
Member

@DeMoorJasper DeMoorJasper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you run prettier over this using yarn format and ensure CI/CD passes

@devongovett
Copy link
Member

This is still editing Parcel 1, not Parcel 2. Doesn't look like we have css source map support in v2 at all yet?

@height
Copy link

height bot commented Feb 5, 2020

This pull request has been linked to T-302.

@height
Copy link

height bot commented Feb 5, 2020

This pull request has been linked to T-296.

@DeMoorJasper
Copy link
Member

DeMoorJasper commented Feb 22, 2020

Gonna close this as v2 has no source maps in css yet.

Feel free to contribute css sourcemaps support for parcel 2

@height
Copy link

height bot commented Feb 22, 2020

This pull request has been linked to T-232.

@height
Copy link

height bot commented Mar 22, 2020

This pull request has been linked to 21 tasks:

💡Tip: Add "Close T-190" to the pull request title or description, to a commit message, or in a comment to mark this task as "Done" when the pull request is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants