Add support for excluding specific node_modules #4072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark Resultspackages/benchmarks/kitchen-sink ✅
Timings
Cold Bundles
Cached Bundles
packages/benchmarks/react-hn ✅
Timings
Cold BundlesNo bundle changes detected. Cached Bundles
packages/benchmarks/ak-editor ✅
Timings
Cold Bundles
Cached Bundles
|
|
I do think we should have a general exclude as well, with either a custom or peerDependency field. |
DeMoorJasper
approved these changes
Feb 3, 2020
This was referenced Mar 21, 2020
|
How is this supposed to work for browser builds? I’m using: {
"browser": "web/dist/app.js",
"source": "frontend/js/app.js",
"targets": {
"browser": {
"includeNodeModules": {
"jquery": false
}
}
}
}It builds But if I do (see #3963): {
"default": "web/dist/app.js",
"source": "frontend/js/app.js",
"targets": {
"default": {}
},
}Then it builds without How can I setup Parcel 2 to build for browser (without Combination of: {
"default": "web/dist/app.js",
"source": "frontend/js/app.js",
"targets": {
"default": {
"includeNodeModules": {
"jquery": false
}
}
}
}yields: |
|
I wish to use it like with an old v1 Parcel and its {
"dependencies": {
"bootstrap": "^4.4.1",
"jquery": "^3.3.1",
"popper.js": "^1.15.0"
},
"devDependencies": {
"less": "^3.11.1",
"parcel-bundler": "^1.12.4",
"parcel-plugin-externals": "^0.2.0"
},
"browserslist": [
"> 1%",
"not dead"
],
"main": "web/dist/app.js",
"source": "frontend/js/app.js",
"externals": {
"jquery": "jQuery",
"bootstrap": true,
"popper.js": true
}
}In my code I use It works in v1, so I’m just wondering if this is possible in Parcel v2. Otherwise, what’s the profit of using external React or something if output code is not runnable in browsers? |
This was referenced Jul 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #144, #3305, #3753.
This adds support for excluding specific node_modules from a bundle. The inverse was already possible via
includeNodeModulesusing the array syntax, but now it's possible to use object syntax to exclude specific node_modules in a certain target.{ "targets": { "library": { "includeNodeModules": { "react": false } } } }#3753 proposed doing this via
peerDependencies, but that doesn't allow specifying node modules to include/exclude per target. We may want to support it as a shortcut forincludeNodeModulesacross all targets, however.