CSS SourceMaps #4440
Merged
CSS SourceMaps #4440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
wbinnssmith
force-pushed
the
wbinnssmith/css-sourcemaps
branch
4 times, most recently
from
ad88371
to
3eee749
Compare
DeMoorJasper
requested changes
Apr 6, 2020
|
(The extensive tests I once added in #2489 still exist in |
wbinnssmith
force-pushed
the
wbinnssmith/css-sourcemaps
branch
from
3eee749
to
d5cdff8
Compare
wbinnssmith
force-pushed
the
wbinnssmith/css-sourcemaps
branch
from
d5cdff8
to
51dc23e
Compare
Those use the old |
Benchmark ResultsKitchen Sink ✅
Timings
Cold Bundles
Cached Bundles
React HackerNews ✅
Timings
Cold Bundles
Cached Bundles
AtlasKit Editor ✅
Timings
Cold Bundles
Cached Bundles
Three.js x4 🚨
Timings
Cold BundlesNo bundles found, this is probably a failed build... Cached BundlesNo bundles found, this is probably a failed build... |
|
@wbinnssmith the new source-map package is fully compatible with the old one, main differences is that it's no longer async and a lot stricter. (ie addMap moved into various different functions addIndexedMappings, addRawMappings, ...) I've updated the tests, they're pretty much all failing somewhere so the maps should be incorrect at the moment. Also updated the typescript sourcemap tests as they were still disabled, shouldn't have any negative impact on this PR |
|
Just pushed a change that allows for mappings corresponding to the nearest contiguous series of spaces or tabs. I also continued skipping LESS and SASS tests as those can be addressed in a followup PR. cc @mischnic @DeMoorJasper |
wbinnssmith
force-pushed
the
wbinnssmith/css-sourcemaps
branch
from
fc51293
to
d55c33f
Compare
wbinnssmith
force-pushed
the
wbinnssmith/css-sourcemaps
branch
from
a0c4200
to
45b72ff
Compare
DeMoorJasper
approved these changes
Apr 15, 2020
mischnic
approved these changes
Apr 15, 2020
|
What about |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we don't produce any sourcemaps for css. This PR uses PostCSS to produce sourcemaps from the CSSTransformer, CSSPackager, and CSSNanoOptimizer.
Currently a work in progress.Test Plan:
yarn test