Added stub for require.cache

[navaru]

↪️ Pull Request

Fixes: #4616

Following the previous #4621 discussion on the same issue, I've made the changes.

✔️ PR Todo

• Added/updated unit tests for this change
• Filled out test instructions (In case there aren't any unit tests)
• Included links to related issues/PRs

[height]

Link Height tasks by mentioning a task ID in the pull request title or description, commit messages, or comments.

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

[DeMoorJasper]

Looks good to, @mischnic could you have a look to validate the changes to scope-hoisting are done properly?

[mischnic]

{
	let module = {
		require() {
			return 1;
		},
	};
	const x = module.require("fs");

	console.log(module, x);
}

Is transformed to ...; var x = null("fs"); ..., you need && !path.scope.hasBinding("module") (and same for require).

Then this should work:

{
	function require() {
		return 1;
	}
	require.cache = [1, 2, 3];
	let module = {
		require,
	};
	const x = module.require("fs");

	console.log(module, module.require("fs"), require.cache[0]);
}

2. The following would throw a cryptic error (Property left of AssignmentExpression expected node to be of a type ["LVal"] but instead got "ObjectExpression") even with the hasBinding check.

{
	require.cache = [1, 2, 3];
	let module = {
		require() {
			return 1;
		},
	};
	const x = module.require("fs");

	console.log(module, module.require("fs"), require.cache[0]);
}

(And these should probably be integration tests as well)

[navaru]

Currently I'm overwhelmed by stuff at work, closing for now, will be back in a couple of weeks.