Tests and improvements to babel config invalidation #5256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to and will mark 1 task as "Done" when merged:
|
devongovett
force-pushed
the
babel-invalidation
branch
from
86648a0
to
564f480
Compare
Benchmark ResultsKitchen Sink ✅
Timings
Cold Bundles
Cached Bundles
React HackerNews ✅
Timings
Cold Bundles
Cached Bundles
AtlasKit Editor ✅
Timings
Cold Bundles
Cached Bundles
Three.js x4 🚨
Timings
Cold BundlesNo bundles found, this is probably a failed build... Cached BundlesNo bundles found, this is probably a failed build... |
padmaia
approved these changes
Oct 28, 2020
Base automatically changed from
parcel-options-invalidation
to
entry-target-invalidations
October 28, 2020 17:32
devongovett
force-pushed
the
babel-invalidation
branch
from
c2189d7
to
a8decc4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1359. Closes T-652.
This improves babel config invalidation and adds cache tests. Most of this depends on babel/babel#11907 which was released in Babel v7.12. This gives us a full list of all files that affected a babel config, including extended configs and ignore files. If we detect an earlier version of babel core, we invalidate on startup and log a warning to let the user know to upgrade. This also implements invalidation on startup for symlinked babel plugins.
The warnings we previously had in the babel transformer weren't really visible to most users because they were logged as verbose. I've changed these to actual warnings so people will be more likely to see them. I've also implemented warning deduplication in the CLI reporter so that the same warning won't be logged for every single file in a build. I think this is probably ok because the number of distinct warnings we actually emit is pretty low.