Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return undefined loc if declaration missing source #7079

Merged
merged 8 commits into from Oct 24, 2021

Conversation

sibbng
Copy link
Contributor

@sibbng sibbng commented Oct 14, 2021

↪️ Pull Request

Fixes #6898

✔️ PR Todo

  • Added/updated unit tests for this change
  • Filled out test instructions (In case there aren't any unit tests)
  • Included links to related issues/PRs

@height
Copy link

height bot commented Oct 14, 2021

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@DeMoorJasper
Copy link
Member

Tests seem to be failing, could you fix them?

@sibbng
Copy link
Contributor Author

sibbng commented Oct 14, 2021

Tests seem to be failing, could you fix them?

Fixed. Remaining failures related to yarn pnp seems persist in v2 branch too.

@sibbng sibbng changed the title Create dummy loc if declaration missing source Return undefined loc if declaration missing source Oct 23, 2021
@sibbng sibbng requested a review from mischnic October 23, 2021 15:06
@mischnic
Copy link
Member

Last thing: can you remove the packages/core/integration-tests/test/integration/postcss-plugins-decl/index.js and use index.js directly as the entry point (and remove await run(b))?

@sibbng
Copy link
Contributor Author

sibbng commented Oct 24, 2021

and use index.js directly as the entry point

I guess, you meant to say index.css here.

@mischnic
Copy link
Member

Yes 👍

@mischnic mischnic merged commit 530e06a into parcel-bundler:v2 Oct 24, 2021
@sibbng sibbng deleted the fix-postcss-decl branch October 24, 2021 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parcel 2 - issue with tailwindcss and JIT only when using @tailwindcss/forms
3 participants