Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't load PostCSS and PostHTML config when inside node_modules #7088

Merged
merged 1 commit into from Oct 14, 2021

Conversation

devongovett
Copy link
Member

No description provided.

@height
Copy link

height bot commented Oct 14, 2021

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@parcel-benchmark
Copy link

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 2.05s -117.00ms 🚀
Cached 266.00ms -48.00ms 🚀

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

React HackerNews ✅

Timings

Description Time Difference
Cold 11.26s +220.00ms
Cached 494.00ms +6.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

Bundle Size Difference Time Difference
dist/logo.c5bb83f1.png 246.00b +0.00b 6.35s +321.00ms ⚠️

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 1.22m -2.38s
Cached 1.75s +33.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

Bundle Size Difference Time Difference
dist/index.390b3d66.js 1.78mb +0.00b 20.37s -1.60s 🚀
dist/EmojiPickerComponent.2bc79859.js 146.67kb +0.00b 22.24s -13.28s 🚀
dist/component.5b4e4410.js 37.35kb +0.00b 20.37s -1.60s 🚀
dist/esm.f1a592e5.js 33.15kb +0.00b 22.24s -13.28s 🚀
dist/component.741edbc5.js 24.94kb +0.00b 20.37s -1.60s 🚀
dist/DatePicker.f2994e45.js 22.98kb +0.00b 22.24s -13.28s 🚀
dist/js.660b75db.js 17.25kb +0.00b 40.63s -15.95s 🚀
dist/component.598bf511.js 6.83kb +0.00b 20.37s -1.34s 🚀
dist/png-chunks-extract.5c9c0fb9.js 3.58kb +0.00b 40.63s -15.95s 🚀
dist/16.4e6ce5ae.js 2.35kb +0.00b 20.37s -1.60s 🚀
dist/date.ada90b9d.js 1.87kb +0.00b 20.37s -1.60s 🚀
dist/images.14c73fbf.js 1.81kb +0.00b 22.23s -1.40s 🚀
dist/feedback.c7e69064.js 1.77kb +0.00b 22.24s -13.28s 🚀
dist/16.f9bcc218.js 1.74kb +0.00b 20.37s -1.34s 🚀
dist/16.8cacdd41.js 1.67kb +0.00b 20.37s -1.34s 🚀
dist/workerHasher.3639b1f9.js 1.63kb +0.00b 22.24s -13.28s 🚀
dist/list-number.8ff56815.js 1.59kb +0.00b 22.23s -1.40s 🚀
dist/status.b77f2884.js 1.59kb +0.00b 22.24s -1.40s 🚀
dist/code.00826c30.js 1.51kb +0.00b 20.37s -1.60s 🚀
dist/heading6.a693146e.js 1.51kb +0.00b 22.24s -13.28s 🚀
dist/heading3.c47f2a80.js 1.50kb +0.00b 22.24s -1.40s 🚀
dist/link.e01a03a1.js 1.43kb +0.00b 22.23s -1.40s 🚀
dist/16.3ea64ad5.js 1.39kb +0.00b 20.37s -1.34s 🚀
dist/heading5.8bfafe21.js 1.38kb +0.00b 22.24s -13.28s 🚀
dist/emoji.0f0d45df.js 1.36kb +0.00b 22.23s -1.40s 🚀
dist/16.dde66fb5.js 1.34kb +0.00b 20.37s -1.34s 🚀
dist/16.17fccf53.js 1.34kb +0.00b 20.37s -1.34s 🚀
dist/16.e572fbc0.js 1.32kb +0.00b 20.37s -1.34s 🚀
dist/heading2.d4e27733.js 1.32kb +0.00b 22.24s -1.40s 🚀
dist/16.82436cab.js 1.32kb +0.00b 20.37s -1.34s 🚀
dist/expand.a44d10fe.js 1.29kb +0.00b 22.24s -13.28s 🚀
dist/16.bbe3d65c.js 1.28kb +0.00b 20.37s -1.34s 🚀
dist/heading4.094fd60f.js 1.27kb +0.00b 22.24s -1.40s 🚀
dist/16.da4ba1b5.js 1.24kb +0.00b 20.37s -1.34s 🚀
dist/16.5076785a.js 1.21kb +0.00b 20.37s -1.34s 🚀
dist/16.b2ed99cf.js 1.20kb +0.00b 20.37s -1.34s 🚀
dist/mention.2459dc08.js 1.20kb +0.00b 22.23s -1.40s 🚀
dist/16.7d56994f.js 1.19kb +0.00b 20.37s -1.34s 🚀
dist/layout.b4aa6b3e.js 1.18kb +0.00b 22.23s -1.40s 🚀
dist/heading1.b05a7fc7.js 1.16kb +0.00b 22.24s -1.40s 🚀
dist/divider.14c72acd.js 1.16kb +0.00b 22.23s -1.40s 🚀
dist/quote.153c231a.js 1.15kb +0.00b 22.24s -1.40s 🚀
dist/16.4788b572.js 1.15kb +0.00b 20.37s -1.34s 🚀
dist/16.f98e3014.js 1.15kb +0.00b 20.37s -1.34s 🚀
dist/16.10f72c3a.js 1.14kb +0.00b 20.37s -1.34s 🚀
dist/16.d0a606ba.js 1.14kb +0.00b 20.37s -1.34s 🚀
dist/16.75f3718c.js 1.14kb +0.00b 20.37s -1.34s 🚀
dist/action.0ca21388.js 1.14kb +0.00b 20.37s -1.60s 🚀
dist/16.a1253273.js 1.14kb +0.00b 20.37s -1.34s 🚀
dist/component.6377d10b.js 1.13kb +0.00b 20.37s -1.60s 🚀
dist/decision.fe885d3c.js 1.12kb +0.00b 22.23s -1.40s 🚀
dist/panel-warning.ee7c59bf.js 1.12kb +0.00b 22.24s -1.40s 🚀
dist/16.70992eab.js 1.10kb +0.00b 20.37s -1.34s 🚀
dist/list.590bc73a.js 1.09kb +0.00b 22.23s -1.40s 🚀
dist/16.dbb3595d.js 1.06kb +0.00b 20.37s -1.34s 🚀
dist/panel-error.3f2f0480.js 1.02kb +0.00b 22.24s -1.40s 🚀
dist/panel.cd7fe8d3.js 1.01kb +0.00b 22.24s -1.40s 🚀
dist/table.209f2bb0.js 1024.00b +0.00b 22.24s -1.40s 🚀
dist/panel-success.2bcdfb70.js 980.00b +0.00b 22.24s -1.40s 🚀
dist/panel-note.55838b19.js 976.00b +0.00b 22.24s -1.40s 🚀

Three.js ✅

Timings

Description Time Difference
Cold 7.25s -588.00ms 🚀
Cached 411.00ms -40.00ms 🚀

Cold Bundles

Bundle Size Difference Time Difference
dist/Three.js 579.68kb +0.00b 5.34s -422.00ms 🚀

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

@devongovett devongovett merged commit 674539e into v2 Oct 14, 2021
@devongovett devongovett deleted the postcss-config branch October 14, 2021 20:17
@yujingwyh
Copy link

Can you add configuration items? I'm using postcss-pxtorem and found it doesn't work for node_module's files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants