Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't visit the property of non-computed member expressions in the esm2cjs folder #7102

Merged
merged 3 commits into from Oct 18, 2021

Conversation

mischnic
Copy link
Member

@mischnic mischnic commented Oct 15, 2021

Closes #7094

The fix makes sense, but I still don't understand why

import { Foo } from "./media.item";

console.log(<S.Foo />);

didn't work while this already worked correctly:

import { Foo } from "./media.item";

console.log(S.Foo);

@height
Copy link

height bot commented Oct 15, 2021

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@parcel-benchmark
Copy link

parcel-benchmark commented Oct 15, 2021

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 2.38s -13.00ms
Cached 348.00ms +9.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 94.00ms -598.00ms 🚀
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 95.00ms -598.00ms 🚀
dist/modern/parcel.7cdb0fad.webp 102.94kb +0.00b 94.00ms -599.00ms 🚀
dist/legacy/index.96016b08.js 1.59kb +0.00b 1.09s +77.00ms ⚠️
dist/legacy/index.8aaa89c9.js 1.20kb +0.00b 1.09s +78.00ms ⚠️
dist/modern/index.6be20f01.js 1.13kb +0.00b 1.09s +79.00ms ⚠️
dist/legacy/index.html 826.00b +0.00b 1.30s +109.00ms ⚠️
dist/modern/index.html 749.00b +0.00b 1.30s +109.00ms ⚠️
dist/legacy/index.c1bc86aa.css 94.00b +0.00b 1.46s +142.00ms ⚠️
dist/modern/index.57a95cbe.css 94.00b +0.00b 1.46s +143.00ms ⚠️

React HackerNews ✅

Timings

Description Time Difference
Cold 12.51s +447.00ms
Cached 545.00ms +7.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 1.32m -1.44s
Cached 1.91s -70.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Three.js ✅

Timings

Description Time Difference
Cold 8.47s +137.00ms
Cached 467.00ms +19.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

@devongovett devongovett merged commit efe7227 into v2 Oct 18, 2021
@devongovett devongovett deleted the 7094-module-id-skip branch October 18, 2021 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parcel is not liking importing named and exported functions sharing the same name
3 participants