Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reject browser js loader promise with Error object #7236

Merged
merged 9 commits into from Nov 23, 2021
Merged

Reject browser js loader promise with Error object #7236

Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d5ec5cd
fix: create error and reject promise with it
mrkldshv Nov 1, 2021
e8e6a22
Merge branch 'v2' into fix/js-loader-error-object
mrkldshv Nov 1, 2021
890d276
Merge branch 'v2' into fix/js-loader-error-object
mrkldshv Nov 2, 2021
e3d1aff
Merge branch 'v2' into fix/js-loader-error-object
mrkldshv Nov 9, 2021
5c5f04c
fix: add error message
mrkldshv Nov 9, 2021
dd3ab4e
fix: format
mrkldshv Nov 9, 2021
967fdcc
Merge branch 'v2' into fix/js-loader-error-object
mrkldshv Nov 14, 2021
66efd13
Merge branch 'v2' into fix/js-loader-error-object
mrkldshv Nov 15, 2021
dc02d2c
Merge branch 'v2' into fix/js-loader-error-object
mrkldshv Nov 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 5 additions & 2 deletions packages/runtimes/js/src/helpers/browser/js-loader.js
View file
Open in desktop
Expand Up @@ -18,10 +18,13 @@ module.exports = cacheLoader(function loadJSBundle(bundle) {
script.type = 'text/javascript';
script.charset = 'utf-8';
script.src = bundle;
script.onerror = function (e) {
script.onerror = function(e) {
var error = new TypeError(
mrkldshv marked this conversation as resolved.
Show resolved Hide resolved
`Failed to fetch dynamically imported module: ${bundle}.`,
);
mrkldshv marked this conversation as resolved.
Show resolved Hide resolved
script.onerror = script.onload = null;
script.remove();
reject(e);
reject(error);
};

script.onload = function () {
Expand Down