Fix side effects glob matching #7288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Benchmark ResultsKitchen Sink ✅
Timings
Cold BundlesNo bundle changes detected. Cached Bundles
React HackerNews ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. AtlasKit Editor ✅
Timings
Cold Bundles
Cached Bundles
Three.js ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. |
devongovett
approved these changes
Nov 12, 2021
lettertwo
added a commit
that referenced
this pull request
Nov 15, 2021
* v2: (68 commits) Fix RangeError in `not export` error with other file type (#7295) Apply sourcemap in @parcel/transformer-typescript-tsc (#7287) Fix side effects glob matching (#7288) Fix changelog headings v2.0.1 Changelog for v2.0.1 Resolve GLSL relative to the importer, not the asset (#7263) fix: add @parcel/diagnostic as dependency of @parcel/transformer-typescript-types (#7248) Fixed missing "Parcel" export member in Module "@parcel/core" (#7250) Add script to sync engines with core version (#7207) Bump swc (#7216) Make Webpack loader detection regex dramatically faster (#7226) swc optimizer (#7212) Update esbuild in optimizer (#7233) Properly visit member expressions (#7228) Update to prettier 2 (#7209) Fix serve mode with target override and target source fields (#7187) Update package.json to include the repository (#7184) fix #6730: add transformer-raw as dependency of config-webextension (#7193) Log warning instead of crash if image optimizer fails (#7119) ...
lettertwo
added a commit
that referenced
this pull request
Nov 15, 2021
* v2: Fix RangeError in `not export` error with other file type (#7295) Apply sourcemap in @parcel/transformer-typescript-tsc (#7287) Fix side effects glob matching (#7288) Fix changelog headings v2.0.1 Changelog for v2.0.1 Resolve GLSL relative to the importer, not the asset (#7263) fix: add @parcel/diagnostic as dependency of @parcel/transformer-typescript-types (#7248) Fixed missing "Parcel" export member in Module "@parcel/core" (#7250)
lettertwo
added a commit
that referenced
this pull request
Nov 15, 2021
* v2: (68 commits) Fix RangeError in `not export` error with other file type (#7295) Apply sourcemap in @parcel/transformer-typescript-tsc (#7287) Fix side effects glob matching (#7288) Fix changelog headings v2.0.1 Changelog for v2.0.1 Resolve GLSL relative to the importer, not the asset (#7263) fix: add @parcel/diagnostic as dependency of @parcel/transformer-typescript-types (#7248) Fixed missing "Parcel" export member in Module "@parcel/core" (#7250) Add script to sync engines with core version (#7207) Bump swc (#7216) Make Webpack loader detection regex dramatically faster (#7226) swc optimizer (#7212) Update esbuild in optimizer (#7233) Properly visit member expressions (#7228) Update to prettier 2 (#7209) Fix serve mode with target override and target source fields (#7187) Update package.json to include the repository (#7184) fix #6730: add transformer-raw as dependency of config-webextension (#7193) Log warning instead of crash if image optimizer fails (#7119) ...
JonasDoesThings
added a commit
to nxt3AT/sankeydiagram.net
that referenced
this pull request
Apr 9, 2022
…ove known issue from docs see parcel issue parcel-bundler/parcel#7274 and pullrequest parcel-bundler/parcel#7288
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
Closes #7239 (comment)
sideEffectsmatching now behaves like Webpack: https://github.com/webpack/webpack/blob/main/lib/optimize/SideEffectsFlagPlugin.jssideEffectsis either a boolean (which should be clear) or a list of globs that match all not side-effect-free files where:./. So"src/index.js"is equivalent to"./src/index.js"except for"index.js"which is equivalent to**/index.js) so that matches all files in the package with that name.It appears that Rollup doesn't have this last rule: