Only error for empty HTML dependency attributes

[mischnic]

• Only throw the "should not be empty string" error for attributes used in dependencies. Previously, all of these three attributes were "invalid":

<input value="" checked data-x />

• Also, I've added quotes around the attributes name in the error message:

Reported by @folknor in #7318 (comment)

[height]

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

[parcel-benchmark]

Benchmark Results

Kitchen Sink ✅

Timings

Description	Time	Difference
Cold	1.95s	+189.00ms ⚠️
Cached	333.00ms	+23.00ms ⚠️

Cold Bundles

Bundle	Size	Difference	Time	Difference
dist/legacy/parcel.7cdb0fad.webp	102.94kb	+0.00b	92.00ms	+11.00ms ⚠️
dist/legacy/parcel.7cdb0fad.webp	102.94kb	+0.00b	556.00ms	+51.00ms ⚠️
dist/modern/parcel.7cdb0fad.webp	102.94kb	+0.00b	556.00ms	+51.00ms ⚠️
dist/legacy/index.96016b08.js	1.59kb	+0.00b	815.00ms	+78.00ms ⚠️
dist/legacy/index.8aaa89c9.js	1.20kb	+0.00b	816.00ms	+78.00ms ⚠️
dist/modern/index.6be20f01.js	1.13kb	+0.00b	816.00ms	+78.00ms ⚠️
dist/legacy/index.html	826.00b	+0.00b	954.00ms	+98.00ms ⚠️
dist/modern/index.html	749.00b	+0.00b	954.00ms	+98.00ms ⚠️
dist/legacy/index.c1bc86aa.css	94.00b	+0.00b	1.08s	+123.00ms ⚠️
dist/modern/index.57a95cbe.css	94.00b	+0.00b	1.08s	+122.00ms ⚠️

Cached Bundles

Bundle	Size	Difference	Time	Difference
dist/legacy/parcel.7cdb0fad.webp	102.94kb	+0.00b	550.00ms	+460.00ms ⚠️
dist/legacy/index.96016b08.js	1.59kb	+0.00b	828.00ms	+42.00ms ⚠️
dist/legacy/index.8aaa89c9.js	1.20kb	+0.00b	828.00ms	+42.00ms ⚠️
dist/modern/index.6be20f01.js	1.13kb	+0.00b	828.00ms	+42.00ms ⚠️
dist/legacy/index.c1bc86aa.css	94.00b	+0.00b	1.10s	+72.00ms ⚠️
dist/modern/index.57a95cbe.css	94.00b	+0.00b	1.10s	+71.00ms ⚠️

React HackerNews ✅

Timings

Description	Time	Difference
Cold	9.24s	-589.00ms 🚀
Cached	491.00ms	+25.00ms ⚠️

Cold Bundles

Bundle	Size	Difference	Time	Difference
dist/index.js	487.84kb	+0.00b	4.94s	-278.00ms 🚀
dist/PermalinkedComment.73f689ea.js	4.21kb	+0.00b	4.93s	-278.00ms 🚀
dist/UserProfile.1b7befb5.js	1.57kb	+0.00b	4.93s	-279.00ms 🚀
dist/NotFound.e6c89571.js	429.00b	+0.00b	4.94s	-278.00ms 🚀
dist/logo.c5bb83f1.png	246.00b	+0.00b	4.89s	-274.00ms 🚀

Cached Bundles

Bundle	Size	Difference	Time	Difference
dist/index.js	487.84kb	+0.00b	4.90s	-251.00ms 🚀
dist/PermalinkedComment.73f689ea.js	4.21kb	+0.00b	4.90s	-252.00ms 🚀
dist/UserProfile.1b7befb5.js	1.57kb	+0.00b	4.90s	-252.00ms 🚀
dist/NotFound.e6c89571.js	429.00b	+0.00b	4.90s	-253.00ms 🚀
dist/logo.c5bb83f1.png	246.00b	+0.00b	4.84s	-253.00ms 🚀

AtlasKit Editor ✅

Timings

Description	Time	Difference
Cold	56.24s	-3.40s 🚀
Cached	1.38s	+18.00ms

Cold Bundles

Bundle	Size	Difference	Time	Difference
dist/pdfRenderer.dccadd23.js	1.11mb	+0.00b	42.77s	-2.23s 🚀
dist/editorView.af442747.js	594.92kb	+0.00b	41.96s	+9.44s ⚠️
dist/popup.64bc9a82.js	209.67kb	+0.00b	41.96s	+9.44s ⚠️
dist/Toolbar.1af0e801.js	107.23kb	+0.00b	41.96s	+9.44s ⚠️
dist/media-viewer.d950776f.js	74.93kb	+0.00b	42.77s	-2.23s 🚀
dist/card.8ef34b4f.js	62.67kb	+0.00b	42.41s	-2.16s 🚀
dist/card.41e5c61a.js	60.71kb	+0.00b	42.77s	-2.23s 🚀
dist/Modal.cd71eaf3.js	45.33kb	+0.00b	41.96s	+9.44s ⚠️
dist/js.660b75db.js	17.25kb	+0.00b	41.96s	-2.60s 🚀
dist/ui.5d3f7adc.js	14.94kb	+0.00b	41.96s	+9.44s ⚠️
dist/smartMediaEditor.48c8cf63.js	13.25kb	+0.00b	41.96s	+9.44s ⚠️
dist/dropzone.39132d0c.js	12.16kb	+0.00b	41.96s	+9.44s ⚠️
dist/index.b54ac00e.js	6.18kb	+0.00b	42.77s	-2.23s 🚀
dist/card.26823fa1.js	5.77kb	+0.00b	42.41s	-2.16s 🚀
dist/EmojiPickerComponent.0482d6c0.js	3.73kb	+0.00b	41.96s	+9.44s ⚠️
dist/png-chunks-extract.5c9c0fb9.js	3.58kb	+0.00b	41.96s	-2.60s 🚀
dist/index.c6306681.css	3.47kb	+0.00b	42.96s	-2.23s 🚀
dist/dropzone.55bef257.js	3.29kb	+0.00b	41.96s	+9.44s ⚠️
dist/Modal.ecafad9e.js	3.15kb	+0.00b	42.41s	-2.16s 🚀
dist/clipboard.df70240c.js	2.93kb	+0.00b	41.96s	+9.44s ⚠️
dist/ResourcedEmojiComponent.667554b4.js	2.12kb	+0.00b	41.96s	+9.44s ⚠️
dist/browser.4e039ed7.js	1.69kb	+0.00b	41.96s	+9.44s ⚠️
dist/workerHasher.14be1ebc.js	1.63kb	+0.00b	42.77s	-2.23s 🚀
dist/media-card-analytics-error-boundary.c718a9a7.js	1.12kb	+0.00b	41.96s	+9.44s ⚠️
dist/media-picker-analytics-error-boundary.8b2547e5.js	966.00b	+0.00b	41.96s	+9.44s ⚠️
dist/media-viewer-analytics-error-boundary.c928a889.js	966.00b	+0.00b	42.77s	-2.23s 🚀
dist/media-card-analytics-error-boundary.30f51dac.js	962.00b	+0.00b	42.41s	-2.16s 🚀
dist/media-card-analytics-error-boundary.6e65cc90.js	962.00b	+0.00b	42.78s	-2.23s 🚀
dist/simpleHasher.fc0d6100.js	643.00b	+0.00b	41.96s	+9.44s ⚠️
dist/simpleHasher.57fb325c.js	643.00b	+0.00b	42.77s	-2.23s 🚀
dist/index.html	386.00b	+0.00b	42.84s	-2.24s 🚀

Cached Bundles

Bundle	Size	Difference	Time	Difference
dist/index.f2127bb0.js	1.78mb	+0.00b	17.66s	+1.15s ⚠️
dist/editorView.af442747.js	594.92kb	+0.00b	34.26s	+2.05s ⚠️
dist/popup.64bc9a82.js	209.67kb	+0.00b	34.26s	+2.05s ⚠️
dist/EmojiPickerComponent.922af3e4.js	147.13kb	+0.00b	29.04s	+1.91s ⚠️
dist/Toolbar.1af0e801.js	107.23kb	+0.00b	34.26s	+2.05s ⚠️
dist/Modal.cd71eaf3.js	45.33kb	+0.00b	34.26s	+2.06s ⚠️
dist/component.5b4e4410.js	37.35kb	+0.00b	17.66s	+1.15s ⚠️
dist/esm.f1a592e5.js	33.15kb	+0.00b	29.04s	+1.91s ⚠️
dist/component.741edbc5.js	24.94kb	+0.00b	17.66s	+1.15s ⚠️
dist/DatePicker.f2994e45.js	22.98kb	+0.00b	29.04s	+1.91s ⚠️
dist/ui.5d3f7adc.js	14.94kb	+0.00b	34.26s	+2.06s ⚠️
dist/smartMediaEditor.48c8cf63.js	13.25kb	+0.00b	34.26s	+2.05s ⚠️
dist/dropzone.39132d0c.js	12.16kb	+0.00b	34.26s	+2.05s ⚠️
dist/workerHasher.11b8f69d.js	11.83kb	+0.00b	34.26s	+2.05s ⚠️
dist/component.598bf511.js	6.83kb	+0.00b	17.45s	+1.15s ⚠️
dist/media-viewer.a19e03bf.js	4.50kb	+0.00b	34.25s	+2.05s ⚠️
dist/media-viewer.21624a99.js	3.93kb	+0.00b	34.25s	+2.05s ⚠️
dist/EmojiPickerComponent.0482d6c0.js	3.73kb	+0.00b	34.26s	+2.06s ⚠️
dist/dropzone.55bef257.js	3.29kb	+0.00b	34.26s	+2.05s ⚠️
dist/clipboard.df70240c.js	2.93kb	+0.00b	34.26s	+2.05s ⚠️
dist/16.4e6ce5ae.js	2.35kb	+0.00b	17.66s	+1.15s ⚠️
dist/ResourcedEmojiComponent.667554b4.js	2.12kb	+0.00b	34.26s	+2.06s ⚠️
dist/card.47672f0e.js	2.04kb	+0.00b	34.25s	+2.05s ⚠️
dist/date.ada90b9d.js	1.87kb	+0.00b	17.66s	+1.15s ⚠️
dist/images.14c73fbf.js	1.81kb	+0.00b	19.04s	+1.17s ⚠️
dist/feedback.c7e69064.js	1.77kb	+0.00b	29.04s	+1.91s ⚠️
dist/16.f9bcc218.js	1.74kb	+0.00b	17.46s	+1.15s ⚠️
dist/browser.4e039ed7.js	1.69kb	+0.00b	34.26s	+2.05s ⚠️
dist/16.8cacdd41.js	1.67kb	+0.00b	17.45s	+1.15s ⚠️
dist/workerHasher.3639b1f9.js	1.63kb	+0.00b	29.04s	+1.91s ⚠️
dist/list-number.8ff56815.js	1.59kb	+0.00b	19.04s	+1.17s ⚠️
dist/status.b77f2884.js	1.59kb	+0.00b	19.04s	+1.17s ⚠️
dist/code.00826c30.js	1.51kb	+0.00b	17.66s	+1.15s ⚠️
dist/heading6.a693146e.js	1.51kb	+0.00b	29.04s	+1.91s ⚠️
dist/heading3.c47f2a80.js	1.50kb	+0.00b	19.04s	+1.17s ⚠️
dist/link.e01a03a1.js	1.43kb	+0.00b	19.04s	+1.17s ⚠️
dist/16.3ea64ad5.js	1.39kb	+0.00b	17.45s	+1.15s ⚠️
dist/heading5.8bfafe21.js	1.38kb	+0.00b	29.04s	+1.91s ⚠️
dist/emoji.0f0d45df.js	1.36kb	+0.00b	19.04s	+1.17s ⚠️
dist/16.dde66fb5.js	1.34kb	+0.00b	17.45s	+1.15s ⚠️
dist/16.17fccf53.js	1.34kb	+0.00b	17.45s	+1.15s ⚠️
dist/16.e572fbc0.js	1.32kb	+0.00b	17.46s	+1.15s ⚠️
dist/heading2.d4e27733.js	1.32kb	+0.00b	19.04s	+1.17s ⚠️
dist/16.82436cab.js	1.32kb	+0.00b	17.45s	+1.15s ⚠️
dist/expand.a44d10fe.js	1.29kb	+0.00b	29.04s	+1.91s ⚠️
dist/16.bbe3d65c.js	1.28kb	+0.00b	17.46s	+1.15s ⚠️
dist/heading4.094fd60f.js	1.27kb	+0.00b	19.04s	+1.17s ⚠️
dist/16.da4ba1b5.js	1.24kb	+0.00b	17.46s	+1.15s ⚠️
dist/16.5076785a.js	1.21kb	+0.00b	17.45s	+1.15s ⚠️
dist/16.b2ed99cf.js	1.20kb	+0.00b	17.46s	+1.15s ⚠️
dist/mention.2459dc08.js	1.20kb	+0.00b	19.04s	+1.17s ⚠️
dist/16.7d56994f.js	1.19kb	+0.00b	17.46s	+1.15s ⚠️
dist/layout.b4aa6b3e.js	1.18kb	+0.00b	19.04s	+1.17s ⚠️
dist/Modal.ca6d4d94.js	1.16kb	+0.00b	34.26s	+2.06s ⚠️
dist/heading1.b05a7fc7.js	1.16kb	+0.00b	19.04s	+1.17s ⚠️
dist/divider.14c72acd.js	1.16kb	+0.00b	19.04s	+1.17s ⚠️
dist/quote.153c231a.js	1.15kb	+0.00b	19.04s	+1.17s ⚠️
dist/16.4788b572.js	1.15kb	+0.00b	17.46s	+1.15s ⚠️
dist/16.f98e3014.js	1.15kb	+0.00b	17.45s	+1.15s ⚠️
dist/16.10f72c3a.js	1.14kb	+0.00b	17.45s	+1.15s ⚠️
dist/16.d0a606ba.js	1.14kb	+0.00b	17.45s	+1.15s ⚠️
dist/16.75f3718c.js	1.14kb	+0.00b	17.45s	+1.15s ⚠️
dist/action.0ca21388.js	1.14kb	+0.00b	17.66s	+1.15s ⚠️
dist/16.a1253273.js	1.14kb	+0.00b	17.45s	+1.15s ⚠️
dist/component.6377d10b.js	1.13kb	+0.00b	17.66s	+1.15s ⚠️
dist/media-card-analytics-error-boundary.c718a9a7.js	1.12kb	+0.00b	34.26s	+2.05s ⚠️
dist/decision.fe885d3c.js	1.12kb	+0.00b	19.03s	+1.17s ⚠️
dist/panel-warning.ee7c59bf.js	1.12kb	+0.00b	19.04s	+1.17s ⚠️
dist/16.70992eab.js	1.10kb	+0.00b	17.45s	+1.15s ⚠️
dist/list.590bc73a.js	1.09kb	+0.00b	19.04s	+1.17s ⚠️
dist/16.dbb3595d.js	1.06kb	+0.00b	17.46s	+1.15s ⚠️
dist/panel-error.3f2f0480.js	1.02kb	+0.00b	19.04s	+1.17s ⚠️
dist/panel.cd7fe8d3.js	1.01kb	+0.00b	19.04s	+1.17s ⚠️
dist/table.209f2bb0.js	1024.00b	+0.00b	19.04s	+1.17s ⚠️
dist/panel-success.2bcdfb70.js	980.00b	+0.00b	19.04s	+1.17s ⚠️
dist/panel-note.55838b19.js	976.00b	+0.00b	19.04s	+1.17s ⚠️
dist/media-picker-analytics-error-boundary.8b2547e5.js	966.00b	+0.00b	34.26s	+2.05s ⚠️
dist/simpleHasher.fc0d6100.js	643.00b	+0.00b	34.26s	+2.06s ⚠️

Three.js ✅

Timings

Description	Time	Difference
Cold	6.07s	-324.00ms 🚀
Cached	362.00ms	-14.00ms

Cold Bundles

Bundle	Size	Difference	Time	Difference
dist/Three.js	579.68kb	+0.00b	4.42s	-291.00ms 🚀

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

[Shinyaigeek]

I’m sorry I made a mistake, and Thank you for a nice catch ! 🙇