Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong does not export error because of missing symbols #7432

Merged
merged 2 commits into from Dec 12, 2021

Conversation

mischnic
Copy link
Member

Regression from #7222 @thebriando

We have this exports_locals map that maps local bindings to their (potential) exported name. So const x = 2; export {x as y} would be { x -> y }. Previously, this map was also populated by export ... from "something"; which are of course not actually local bindings.

We actually had an integration test for this, but apparently in this case the order of export { x as y } from and export x mattered.

@height
Copy link

height bot commented Dec 11, 2021

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@parcel-benchmark
Copy link

parcel-benchmark commented Dec 11, 2021

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 1.99s -3.00ms
Cached 334.00ms -13.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 557.00ms -50.00ms 🚀
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 558.00ms -50.00ms 🚀
dist/modern/parcel.7cdb0fad.webp 102.94kb +0.00b 557.00ms -51.00ms 🚀
dist/legacy/index.96016b08.js 1.59kb +0.00b 825.00ms -54.00ms 🚀
dist/legacy/index.8aaa89c9.js 1.20kb +0.00b 825.00ms -54.00ms 🚀
dist/modern/index.6be20f01.js 1.13kb +0.00b 824.00ms -56.00ms 🚀
dist/legacy/index.html 826.00b +0.00b 966.00ms -64.00ms 🚀
dist/modern/index.html 749.00b +0.00b 966.00ms -67.00ms 🚀

Cached Bundles

No bundle changes detected.

React HackerNews ✅

Timings

Description Time Difference
Cold 11.17s +1.19s ⚠️
Cached 460.00ms -53.00ms 🚀

Cold Bundles

Bundle Size Difference Time Difference
dist/index.js 487.84kb +0.00b 5.88s +553.00ms ⚠️
dist/PermalinkedComment.73f689ea.js 4.21kb +0.00b 5.88s +554.00ms ⚠️
dist/UserProfile.1b7befb5.js 1.57kb +0.00b 5.88s +554.00ms ⚠️
dist/NotFound.e6c89571.js 429.00b +0.00b 5.88s +554.00ms ⚠️
dist/logo.c5bb83f1.png 246.00b +0.00b 5.85s +574.00ms ⚠️

Cached Bundles

No bundle changes detected.

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 1.21m -655.00ms
Cached 1.69s -71.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

Bundle Size Difference Time Difference
dist/editorView.124f5fc0.js 594.92kb +0.00b 39.91s -14.36s 🚀
dist/popup.64bc9a82.js 209.67kb +0.00b 39.91s -14.36s 🚀
dist/Toolbar.1af0e801.js 107.23kb +0.00b 39.91s -14.36s 🚀
dist/Modal.cd71eaf3.js 45.33kb +0.00b 39.91s -14.36s 🚀
dist/ui.5d3f7adc.js 14.94kb +0.00b 39.91s -14.36s 🚀
dist/smartMediaEditor.48c8cf63.js 13.25kb +0.00b 39.91s -14.36s 🚀
dist/dropzone.39132d0c.js 12.16kb +0.00b 39.91s -14.36s 🚀
dist/EmojiPickerComponent.0482d6c0.js 3.73kb +0.00b 39.91s -14.36s 🚀
dist/dropzone.55bef257.js 3.29kb +0.00b 39.91s -14.36s 🚀
dist/clipboard.df70240c.js 2.93kb +0.00b 39.91s -14.36s 🚀
dist/ResourcedEmojiComponent.667554b4.js 2.12kb +0.00b 39.91s -14.36s 🚀
dist/browser.4e039ed7.js 1.69kb +0.00b 39.91s -14.36s 🚀
dist/media-card-analytics-error-boundary.c718a9a7.js 1.12kb +0.00b 39.91s -14.36s 🚀
dist/media-picker-analytics-error-boundary.8b2547e5.js 966.00b +0.00b 39.91s -14.36s 🚀
dist/simpleHasher.fc0d6100.js 643.00b +0.00b 39.91s -14.36s 🚀

Three.js ✅

Timings

Description Time Difference
Cold 7.67s +116.00ms
Cached 422.00ms +5.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

@thebriando
Copy link
Member

LGTM

@devongovett devongovett merged commit d9e47a1 into v2 Dec 12, 2021
@devongovett devongovett deleted the fixup-hoist-symbols branch December 12, 2021 01:11
bhovhannes pushed a commit to bhovhannes/parcel that referenced this pull request Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants