Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply segfault workaround to image optimizer as well #7461

Merged
merged 1 commit into from Dec 17, 2021

Conversation

devongovett
Copy link
Member

Another case of rust-lang/rust#91979. Same fix as #7457.

@height
Copy link

height bot commented Dec 17, 2021

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@parcel-benchmark
Copy link

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 1.80s +16.00ms
Cached 302.00ms -4.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 236.00ms -281.00ms 🚀
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 237.00ms -281.00ms 🚀
dist/modern/parcel.7cdb0fad.webp 102.94kb +0.00b 236.00ms -282.00ms 🚀

Cached Bundles

No bundle changes detected.

React HackerNews ✅

Timings

Description Time Difference
Cold 8.82s -145.00ms
Cached 420.00ms +10.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 58.68s +336.00ms
Cached 1.36s -28.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/editorView.af442747.js 594.92kb +0.00b 44.09s +11.74s ⚠️
dist/popup.64bc9a82.js 209.67kb +0.00b 44.09s +11.74s ⚠️
dist/Toolbar.1af0e801.js 107.23kb +0.00b 44.09s +11.74s ⚠️
dist/Modal.cd71eaf3.js 45.33kb +0.00b 44.09s +11.74s ⚠️
dist/ui.5d3f7adc.js 14.94kb +0.00b 44.09s +11.74s ⚠️
dist/smartMediaEditor.48c8cf63.js 13.25kb +0.00b 44.09s +11.74s ⚠️
dist/dropzone.39132d0c.js 12.16kb +0.00b 44.09s +11.74s ⚠️
dist/EmojiPickerComponent.0482d6c0.js 3.73kb +0.00b 44.09s +11.74s ⚠️
dist/dropzone.55bef257.js 3.29kb +0.00b 44.09s +11.74s ⚠️
dist/clipboard.df70240c.js 2.93kb +0.00b 44.09s +11.74s ⚠️
dist/ResourcedEmojiComponent.667554b4.js 2.12kb +0.00b 44.09s +11.74s ⚠️
dist/browser.4e039ed7.js 1.69kb +0.00b 44.09s +11.74s ⚠️
dist/media-card-analytics-error-boundary.c718a9a7.js 1.12kb +0.00b 44.09s +11.74s ⚠️
dist/media-picker-analytics-error-boundary.8b2547e5.js 966.00b +0.00b 44.09s +11.74s ⚠️
dist/simpleHasher.fc0d6100.js 643.00b +0.00b 44.09s +11.74s ⚠️

Cached Bundles

No bundle changes detected.

Three.js ✅

Timings

Description Time Difference
Cold 6.22s +71.00ms
Cached 356.00ms -15.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

@devongovett devongovett merged commit eb2ccde into v2 Dec 17, 2021
@devongovett devongovett deleted the segfault-workaround2 branch December 17, 2021 01:58
bhovhannes pushed a commit to bhovhannes/parcel that referenced this pull request Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants